Lightpack
Lightpack copied to clipboard
Atarity
Library injector refactoring
This is a complex pull-request, but I think it can be useful to project. First, I've fixed compilation with Microsoft compiler. I have almost fixed compilation of the whole Prismatic project with MSVS, so later I can send you patch if you don't mind. As far as I know it is not a default compiler for this project, but the code is good enough to compile and run using this compiler. After that, I've made some refactoring to make code simpler. Also I don't like compiler warnings, so I tried to fix most of them. Hope it can help.
Hi. Would you provide some reaction for this pull-request, please? Are you interested in requests like this?
I fixed compilation of Prismatic project with Qt5.2.0 for Win32/MacOS 10.8, you can check my code here - https://github.com/dreamer-dead/Lightpack/commits/fix-compilation-qt5.2.0 During this work I have fixed some errors and I think that you can use my code to make this project better. So I can make few pull-requests with my fixes. What do you think about this?
Hi, Sure i'm interested in your requests! I just working on piece of code for Linux, so i couldn't test the request so quick. I really appreciate your contribution! I'm going to test it on Sunday-Monday and if it is ok it will be released on Tuesday or day after. Other commits/requests will be included to following releases, so shoot .) Thanks again and best regards.
OK, glad to hear that! I tried not to change any code-flow or logic except error fixes, so I hope that I didn't broke anything. I'll try to send small changes in every pull-request to make the review simplier.