async-http-client icon indicating copy to clipboard operation
async-http-client copied to clipboard

Support Socks4/5 Proxy

Open Lekanich opened this issue 10 years ago • 21 comments

Can you add support socks proxy for netty provider? It was be wonderfull.

Lekanich avatar Apr 11 '14 16:04 Lekanich

Contribution welcome

slandelle avatar Apr 11 '14 16:04 slandelle

Ok, I will make a new fork and write.

Lekanich avatar Apr 23 '14 14:04 Lekanich

What java version I must use for this? (JAVA 6, 7, 8?)

Lekanich avatar Apr 24 '14 11:04 Lekanich

If it's for 2.0, you can use 7. If for 1.8.x, use 6.

jfarcand avatar Apr 24 '14 13:04 jfarcand

What branch is 2.0?

Lekanich avatar Apr 25 '14 13:04 Lekanich

master

slandelle avatar Jun 12 '14 11:06 slandelle

@slandelle Thanks

Lekanich avatar Jun 12 '14 18:06 Lekanich

@Lekanich Well, you're the one who deserves thanks. Referencing your Netty WIP: https://github.com/netty/netty/pull/2563

slandelle avatar Jun 12 '14 18:06 slandelle

I am interesting in this too and will be keen on contributing.

What's the status of it and is there a wip branch where I can have a look at the current progress and help?

bchazalet avatar Jun 06 '15 11:06 bchazalet

Hi @bchazalet,

Honestly, I have no idea where SOCKS support in Netty is now. From @trustin's comment here, I'm not sure it has support for client side sockets yet. If you're interested in contributing, the best way would probably be to first get in touch with the Netty people and make the feature happen there. Then, we'll be able to wrap it in AHC.

slandelle avatar Jun 06 '15 12:06 slandelle

thanks for the info @slandelle

bchazalet avatar Jun 06 '15 12:06 bchazalet

ah @bchazalet ... we need this too... as we use ssh tunneling with dynamic forward to local port

jeffpeiyt avatar Aug 05 '15 19:08 jeffpeiyt

@bchazalet , after a year.... does netty support this now?

jeffpeiyt avatar Aug 05 '15 19:08 jeffpeiyt

AFAIK, Netty 4 now has SOCKS support. But even if AHC 2 (currently in alpha) supports Netty 4, there's no integration for this codec. Honestly, the best way to make it happen is to contribute it.

slandelle avatar Aug 05 '15 20:08 slandelle

@slandelle How would you implement this? Can you throw a couple of pointers on where to start? And what codec are you talking about?

Sorry for the naive questions, but I guess I have a lot of reading on both projects.

bchazalet avatar Aug 05 '15 21:08 bchazalet

@bchazalet A good starting point would be to look at the test case in Netty:

https://github.com/netty/netty/blob/4.1/handler-proxy/src/test/java/io/netty/handler/proxy/ProxyHandlerTest.java

It tests various cases, but they are essentially same.

  • Insert proxy handlers into the pipeline
  • Attempt to connect to a unresolved address if you want proxy-side DNS resolution
  • Use NoopNameResolverGroup as a resolver.

trustin avatar Aug 21 '15 05:08 trustin

I need socks5 support also.

egprentice avatar Nov 18 '15 19:11 egprentice

I need too!

hsrzq avatar Apr 28 '16 10:04 hsrzq

But I don't. So there's 2 ways to make this happen:

  • contributing: there's some ideas and links in there
  • contracting

slandelle avatar Apr 28 '16 11:04 slandelle

No activity there for a very long time. Closing for now.

slandelle avatar Jun 21 '17 07:06 slandelle

Adding support for Socks5; PR will be up soon.

hyperxpro avatar Nov 11 '23 07:11 hyperxpro