async-http-client
async-http-client copied to clipboard
Support Socks4/5 Proxy
Can you add support socks proxy for netty provider? It was be wonderfull.
Contribution welcome
Ok, I will make a new fork and write.
What java version I must use for this? (JAVA 6, 7, 8?)
If it's for 2.0, you can use 7. If for 1.8.x, use 6.
What branch is 2.0?
master
@slandelle Thanks
@Lekanich Well, you're the one who deserves thanks. Referencing your Netty WIP: https://github.com/netty/netty/pull/2563
I am interesting in this too and will be keen on contributing.
What's the status of it and is there a wip branch where I can have a look at the current progress and help?
Hi @bchazalet,
Honestly, I have no idea where SOCKS support in Netty is now. From @trustin's comment here, I'm not sure it has support for client side sockets yet. If you're interested in contributing, the best way would probably be to first get in touch with the Netty people and make the feature happen there. Then, we'll be able to wrap it in AHC.
thanks for the info @slandelle
ah @bchazalet ... we need this too... as we use ssh tunneling with dynamic forward to local port
@bchazalet , after a year.... does netty support this now?
AFAIK, Netty 4 now has SOCKS support. But even if AHC 2 (currently in alpha) supports Netty 4, there's no integration for this codec. Honestly, the best way to make it happen is to contribute it.
@slandelle How would you implement this? Can you throw a couple of pointers on where to start? And what codec are you talking about?
Sorry for the naive questions, but I guess I have a lot of reading on both projects.
@bchazalet A good starting point would be to look at the test case in Netty:
https://github.com/netty/netty/blob/4.1/handler-proxy/src/test/java/io/netty/handler/proxy/ProxyHandlerTest.java
It tests various cases, but they are essentially same.
- Insert proxy handlers into the pipeline
- Attempt to connect to a unresolved address if you want proxy-side DNS resolution
- Use
NoopNameResolverGroup
as a resolver.
I need socks5 support also.
I need too!
But I don't. So there's 2 ways to make this happen:
- contributing: there's some ideas and links in there
- contracting
No activity there for a very long time. Closing for now.
Adding support for Socks5; PR will be up soon.