async-http-client icon indicating copy to clipboard operation
async-http-client copied to clipboard

Published 20 hours ago • verified publisher icon AsyncHttpClient

Remove ResponseBodyPartFactory.LAZY

Open TomGranot opened this issue 4 years ago • 2 comments

Following https://github.com/AsyncHttpClient/async-http-client/issues/1765#issuecomment-765416561.

TomGranot avatar Jan 22 '21 18:01 TomGranot

Hello, I found that ResponseBodyPartFactory.LAZY avoids copying data to java heap compared to ResponseBodyPartFactory.EAGER.

It should be useful in some scenarios. I think it should be good for performance. Compared with other java http client, it is also more flexible, but my usage is wrong. Could you please consider not deleting ResponseBodyPartFactory.LAZY? And consider how to use the prompt error?

Sorry, I am not an expert, this is just my suggestion. Thank you

lakxtxue avatar Jan 23 '21 04:01 lakxtxue

@lakxtxue Sure, I'll take a closer look at when and how it's useful before removing it.

This is lower on the TODO list anyhow, so it's not expected to be removed anytime soon. :)

Thanks for chiming in!

TomGranot avatar Jan 23 '21 07:01 TomGranot