async-http-client icon indicating copy to clipboard operation
async-http-client copied to clipboard

Published 20 hours ago • verified publisher icon AsyncHttpClient

Investigate DNS failures in testMaxTotalConnectionsTest

Open TomGranot opened this issue 4 years ago • 1 comments

See https://github.com/AsyncHttpClient/async-http-client/pull/1753 and elaborate more given time.

@slandelle you mentioned this has to do with Travis's DNS resolution, but I can confirm this fails also on my own machine and on GitHub actions. If you have any other insight / past experience with this do tell, but I'm leaving it here for later exploration.

TomGranot avatar Dec 12 '20 17:12 TomGranot

#1753 fixes that in a rather stupid way - by making the test a bit more granular to avoid any reliance on the exact exception thrown during the test. Instead, it now opts to observe the cause of the exception and use that as well as the exception type.

I'd like to keep this open to revisit the test eventually since I feel it's going to come back and bite me in the future.

TomGranot avatar Dec 12 '20 20:12 TomGranot