async-http-client icon indicating copy to clipboard operation
async-http-client copied to clipboard

Support WebSocket auto-reconnect

Open zhp0260 opened this issue 5 years ago • 5 comments

last year, i used the websocket function, I find when the server disconnect the nettywebsocket client, then I don't know how reconnect the server side. I just only close this asyncHttpClient and renew a websocket. I think it is not well for it, the framework should be support reconnect, make it for reuse.

zhp0260 avatar Mar 19 '20 06:03 zhp0260

Contributions welcome.

slandelle avatar Mar 19 '20 08:03 slandelle

I can take a look at it.

sivaalli avatar Apr 08 '20 20:04 sivaalli

@sivaalli Sure, feel free to take a stab at it. But I advice you only do so if you have a need for this on an actual use case.

From my experience, for lots of applications, re-opening a WebSocket is not just a matter of re-connecting but actually requires some application logic such as sending again some authentication message or renewing a token.

So far, only one single perso has requested this. IMHO, this is not enough feedback yet to decide to invest time on this.

slandelle avatar Apr 08 '20 21:04 slandelle

Agreed. I do not specifically need this use case. If there is traction on this request, I will revisit. Thanks :)

sivaalli avatar Apr 10 '20 04:04 sivaalli

@slandelle I propose we close this since indeed no traction.

TomGranot avatar Sep 28 '20 15:09 TomGranot