async-http-client icon indicating copy to clipboard operation
async-http-client copied to clipboard

Published 20 hours ago • verified publisher icon AsyncHttpClient

Support for OpenSslEngine with no finalizer

Open johnou opened this issue 5 years ago • 5 comments

Motivation:

Custom SslContext should be retained on init.

Modification:

Retain custom SslContext.

Result:

Externally managed SslContext refcount is managed correctly.

johnou avatar Feb 05 '20 09:02 johnou

Follow up for https://github.com/AsyncHttpClient/async-http-client/pull/1669

@normanmaurer ptal

johnou avatar Feb 05 '20 09:02 johnou

Why? In this case, SslContext is provided by the user so he has control over ref count. Moreover, isn’t it created with a refcount of 1?

slandelle avatar Feb 05 '20 10:02 slandelle

@slandelle yep but then it is decreased in destroy. point is user should know if they haven't cleaned up any resources, so in the case we are dealing with an SslContext provided by the user, refcount will be incremented to 2, then decremented back to 1 once destroy is invoked on the SslEngineFactory.

johnou avatar Feb 05 '20 10:02 johnou

I don't think the test failures are related..

Tests run: 15, Failures: 6, Errors: 0, Skipped: 0, Time elapsed: 4.185 sec <<< FAILURE! - in TestSuite
testAbort(org.asynchttpclient.extras.rxjava.single.AsyncHttpSingleTest)  Time elapsed: 2.447 sec  <<< FAILURE!
java.lang.AssertionError: Unexpected onError events (0 completions) (+1 error)
	at org.asynchttpclient.extras.rxjava.single.AsyncHttpSingleTest.testAbort(AsyncHttpSingleTest.java:282)
Caused by: java.net.UnknownHostException: DNS name not found [response code 3]
	at org.asynchttpclient.extras.rxjava.single.AsyncHttpSingleTest.testAbort(AsyncHttpSingleTest.java:277)

testObserveError(org.asynchttpclient.extras.rxjava.AsyncHttpObservableTest)  Time elapsed: 0.049 sec  <<< FAILURE!
java.lang.AssertionError: Unexpected onError events (0 completions) (+1 error)
	at org.asynchttpclient.extras.rxjava.AsyncHttpObservableTest.testObserveError(AsyncHttpObservableTest.java:98)
Caused by: java.net.UnknownHostException: gatling.io
	at org.asynchttpclient.extras.rxjava.AsyncHttpObservableTest.testObserveError(AsyncHttpObservableTest.java:94)

testObserveMultiple(org.asynchttpclient.extras.rxjava.AsyncHttpObservableTest)  Time elapsed: 0.2 sec  <<< FAILURE!
java.lang.AssertionError: Unexpected onError events (0 completions) (+1 error)
	at org.asynchttpclient.extras.rxjava.AsyncHttpObservableTest.testObserveMultiple(AsyncHttpObservableTest.java:121)
Caused by: java.net.UnknownHostException: gatling.io
	at org.asynchttpclient.extras.rxjava.AsyncHttpObservableTest.testObserveMultiple(AsyncHttpObservableTest.java:114)

testObserveNoError(org.asynchttpclient.extras.rxjava.AsyncHttpObservableTest)  Time elapsed: 0.054 sec  <<< FAILURE!
java.lang.AssertionError: Unexpected onError events (0 completions) (+1 error)
	at org.asynchttpclient.extras.rxjava.AsyncHttpObservableTest.testObserveNoError(AsyncHttpObservableTest.java:78)
Caused by: java.net.UnknownHostException: gatling.io
	at org.asynchttpclient.extras.rxjava.AsyncHttpObservableTest.testObserveNoError(AsyncHttpObservableTest.java:74)

testToObservableError(org.asynchttpclient.extras.rxjava.AsyncHttpObservableTest)  Time elapsed: 0.03 sec  <<< FAILURE!
java.lang.AssertionError: Unexpected onError events (0 completions) (+1 error)
	at org.asynchttpclient.extras.rxjava.AsyncHttpObservableTest.testToObservableError(AsyncHttpObservableTest.java:58)
Caused by: java.net.UnknownHostException: gatling.io
	at org.asynchttpclient.extras.rxjava.AsyncHttpObservableTest.testToObservableError(AsyncHttpObservableTest.java:55)

testToObservableNoError(org.asynchttpclient.extras.rxjava.AsyncHttpObservableTest)  Time elapsed: 0.026 sec  <<< FAILURE!
java.lang.AssertionError: Unexpected onError events (0 completions) (+1 error)
	at org.asynchttpclient.extras.rxjava.AsyncHttpObservableTest.testToObservableNoError(AsyncHttpObservableTest.java:38)
Caused by: java.net.UnknownHostException: gatling.io
	at org.asynchttpclient.extras.rxjava.AsyncHttpObservableTest.testToObservableNoError(AsyncHttpObservableTest.java:35)


Results :

Failed tests: 
  AsyncHttpObservableTest.testObserveError:98 Unexpected onError events (0 completions) (+1 error)
  AsyncHttpObservableTest.testObserveMultiple:121 Unexpected onError events (0 completions) (+1 error)
  AsyncHttpObservableTest.testObserveNoError:78 Unexpected onError events (0 completions) (+1 error)
  AsyncHttpObservableTest.testToObservableError:58 Unexpected onError events (0 completions) (+1 error)
  AsyncHttpObservableTest.testToObservableNoError:38 Unexpected onError events (0 completions) (+1 error)
  AsyncHttpSingleTest.testAbort:282 Unexpected onError events (0 completions) (+1 error)

johnou avatar Feb 05 '20 11:02 johnou

The other possible solution is something like this.. https://gist.github.com/johnou/4c699909ef9be3c030eaee29432c1ce3#file-defaultsslenginefactory-java-L34

johnou avatar Feb 05 '20 11:02 johnou