php-deepface icon indicating copy to clipboard operation
php-deepface copied to clipboard

Removed try-catch from script, add regex to replace newline

Open pablo-gbr opened this issue 1 year ago • 2 comments

Last pull request (#14) introduced a serious problem when running any script in a single line (python won't run a script with a try-except block in a single line because indentations, see #15 for more details).

Also, running the package on a linux-based server throws an error related with newline not being replaced correctly.

This PR should address all of this.

pablo-gbr avatar Jul 15 '24 14:07 pablo-gbr

I need feedback on 753c104 in order to change how to handle exceptions in such cases.

pablo-gbr avatar Jul 15 '24 14:07 pablo-gbr

Requesting review from @Gummibeer to merge this asap

pablo-gbr avatar Aug 01 '24 12:08 pablo-gbr

I think that's no longer needed as of latest main changes!?

Gummibeer avatar Dec 19 '24 17:12 Gummibeer

There's a new release: https://github.com/Astrotomic/php-deepface/releases/tag/0.4.0

Gummibeer avatar Dec 20 '24 00:12 Gummibeer

Sorry for the late reply, there's no need to merge this anymore. Closing this (:

pablo-gbr avatar Jan 09 '25 14:01 pablo-gbr