astrocommunity icon indicating copy to clipboard operation
astrocommunity copied to clipboard

feat: Remove <Leader>f mapping from community plugin

Open shivanthzen opened this issue 8 months ago • 4 comments

📑 Description

ℹ Additional Information

shivanthzen avatar Apr 06 '25 13:04 shivanthzen

Review Checklist

Does this PR follow the [Contribution Guidelines](development guidelines)? Following is a partial checklist:

Proper conventional commit scoping:

  • If you are adding a new plugin, the scope would be the name of the category it is being added into. ex. feat(utility): added noice.nvim plugin

  • If you are modifying a pre-existing plugin or pack, the scope would be the name of the plugin folder. ex. fix(noice-nvim): fix LSP handler error

  • [x] Pull request title has the appropriate conventional commit type and scope where the scope is the name of the pre-existing directory in the project as described above

  • [x] README is properly formatted and uses fenced in links with <url> unless they are inside a [title](url)

  • [x] Entry returns a single plugin spec with the new plugin as the only top level spec (not applicable for recipes or packs).

  • [x] Proper usage of opts table rather than setting things up with the config function.

  • [x] Proper usage of specs table for all specs that are not dependencies of a given plugin (not applicable for recipes or packs).

github-actions[bot] avatar Apr 06 '25 13:04 github-actions[bot]

What is the reason to remove it? It conflicts with an existing mapping?

azdanov avatar Apr 08 '25 05:04 azdanov

.image

<leader>f is prefix for all picker actions. It actually overlaps. Wouldn't it be better to remap it? <leader>ue for example. <leader>ue and <leader>uE are not mentioned in astrocommunity/

ButterSus avatar Apr 14 '25 08:04 ButterSus

Any updates on this? @shivanthzen

Uzaaft avatar Apr 25 '25 07:04 Uzaaft

@Uzaaft

shivanthzen avatar Apr 30 '25 14:04 shivanthzen

Answer the question that azdanov asked @shivanthzen before pinging me...

Uzaaft avatar Apr 30 '25 15:04 Uzaaft

<leader>f is prefix for all picker actions. It actually overlaps. Wouldn't it be better to remap it? <leader>ue for example. <leader>ue and <leader>uE are not mentioned in astrocommunity/

Already answered here

shivanthzen avatar Apr 30 '25 17:04 shivanthzen

Looks good. Thanks! @Uzaaft what do you think? Seems like a breaking change, so I updated the title accordingly.

azdanov avatar May 01 '25 02:05 azdanov