astrocommunity icon indicating copy to clipboard operation
astrocommunity copied to clipboard

feat: adding snacks.nvim plugins

Open luxus opened this issue 1 year ago • 22 comments

adding snacks from our friend folke. i just copied the install instruction and modified it a little to make them fit into astrocommunity, i'm sure im missing something and collide with some keybindings

luxus avatar Nov 08 '24 17:11 luxus

Review Checklist

Does this PR follow the [Contribution Guidelines](development guidelines)? Following is a partial checklist:

Proper conventional commit scoping:

  • If you are adding a new plugin, the scope would be the name of the category it is being added into. ex. feat(utility): added noice.nvim plugin

  • If you are modifying a pre-existing plugin or pack, the scope would be the name of the plugin folder. ex. fix(noice-nvim): fix LSP handler error

  • [ ] Pull request title has the appropriate conventional commit type and scope where the scope is the name of the pre-existing directory in the project as described above

  • [ ] README is properly formatted and uses fenced in links with <url> unless they are inside a [title](url)

  • [ ] Entry returns a single plugin spec with the new plugin as the only top level spec (not applicable for recipes or packs).

  • [ ] Proper usage of opts table rather than setting things up with the config function.

  • [ ] Proper usage of specs table for all specs that are not dependencies of a given plugin (not applicable for recipes or packs).

github-actions[bot] avatar Nov 08 '24 17:11 github-actions[bot]

i think this News <Leader>N is just a PoC and not really useful? :D

luxus avatar Nov 11 '24 17:11 luxus

i think this News <Leader>N is just a PoC and not really useful? :D

Agreed.

Uzaaft avatar Nov 11 '24 20:11 Uzaaft

should not toggleterm be fully replaced with that? @mehalter

luxus avatar Nov 11 '24 20:11 luxus

Yeah I think it should, I think you mentioned above you were gonna do it 😂

mehalter avatar Nov 11 '24 20:11 mehalter

It should probably be default override toggleterm but if the user manually re-enables it then it should go back to the defaults in AstroNvim

mehalter avatar Nov 11 '24 20:11 mehalter

if i wait long enough, hopefully it will fix by itself :-D

luxus avatar Nov 11 '24 20:11 luxus

Ready for review?

Uzaaft avatar Nov 16 '24 19:11 Uzaaft

There still needs to be work done to replace toggleterm stuff

mehalter avatar Nov 17 '24 04:11 mehalter

i checked snacks, dunno how to do a float without a cmd not sure how to emulate <Leader>tf

luxus avatar Nov 17 '24 21:11 luxus

i checked snacks, dunno how to do a float without a cmd not sure how to emulate <Leader>tf

I peeked into source code, this snippet works for me

        maps.n["<Leader>tf"] = {
          function() Snacks.terminal(nil, { win = { position = "float" } }) end,
          desc = "Toggle Terminal Float",
        }

RayJameson avatar Dec 01 '24 19:12 RayJameson

Wish one day Snacks can be part of the core and replaces a ton of core plugins.

liujoey avatar Dec 14 '24 00:12 liujoey

They don't really provide much and I'm not a fan of the structure personally. They also aren't super full featured and aren't particularly good replacements for the masses

mehalter avatar Dec 14 '24 00:12 mehalter

yeah i have mixed feelings too, i like the dashboard and the lazygit with nicer colors. the issue is that many of the stuff needs configuration and people should configure it themself instead of a oppionated version in astrocommunity

luxus avatar Dec 14 '24 07:12 luxus

Also lazygit nice colors had been implemented similarly into AstroUI

mehalter avatar Dec 14 '24 10:12 mehalter

If we are splitting them into individual plugins, would adding a pack for snacks be handy to enable them all?

ALameLlama avatar Feb 08 '25 06:02 ALameLlama

@ALameLlama yeah this is what I imagined would be the case

mehalter avatar Feb 08 '25 06:02 mehalter

I'd like to know what stage it's at now.

acdcbyl avatar Feb 18 '25 16:02 acdcbyl

I'd like to know what stage it's at now.

This PR is still in draft. There are lots of plugins from snacks.nvim still missing.

Uzaaft avatar Feb 18 '25 16:02 Uzaaft

I'd like to know what stage it's at now.

This PR is still in draft. There are lots of plugins from snacks.nvim still missing.

Thank you very much

acdcbyl avatar Feb 19 '25 02:02 acdcbyl

since v5 is launched, this seems like its not needed. Wdyt? @luxus @mehalter cc @AstroNvim/astrocommunity-maintainers

Uzaaft avatar Mar 31 '25 10:03 Uzaaft

I think there are still some good stuff in here that are useful like if the user wants to easily opt into the snacks.words or snacks.statuscol

mehalter avatar Mar 31 '25 12:03 mehalter