feat: adding snacks.nvim plugins
adding snacks from our friend folke. i just copied the install instruction and modified it a little to make them fit into astrocommunity, i'm sure im missing something and collide with some keybindings
Review Checklist
Does this PR follow the [Contribution Guidelines](development guidelines)? Following is a partial checklist:
Proper conventional commit scoping:
-
If you are adding a new plugin, the scope would be the name of the category it is being added into. ex.
feat(utility): added noice.nvim plugin -
If you are modifying a pre-existing plugin or pack, the scope would be the name of the plugin folder. ex.
fix(noice-nvim): fix LSP handler error -
[ ] Pull request title has the appropriate conventional commit type and scope where the scope is the name of the pre-existing directory in the project as described above
-
[ ]
READMEis properly formatted and uses fenced in links with<url>unless they are inside a[title](url) -
[ ] Entry returns a single plugin spec with the new plugin as the only top level spec (not applicable for recipes or packs).
-
[ ] Proper usage of
optstable rather than setting things up with theconfigfunction. -
[ ] Proper usage of
specstable for all specs that are not dependencies of a given plugin (not applicable for recipes or packs).
i think this News <Leader>N is just a PoC and not really useful? :D
i think this News
<Leader>Nis just a PoC and not really useful? :D
Agreed.
should not toggleterm be fully replaced with that? @mehalter
Yeah I think it should, I think you mentioned above you were gonna do it 😂
It should probably be default override toggleterm but if the user manually re-enables it then it should go back to the defaults in AstroNvim
if i wait long enough, hopefully it will fix by itself :-D
Ready for review?
There still needs to be work done to replace toggleterm stuff
i checked snacks, dunno how to do a float without a cmd
not sure how to emulate <Leader>tf
i checked snacks, dunno how to do a float without a cmd not sure how to emulate
<Leader>tf
I peeked into source code, this snippet works for me
maps.n["<Leader>tf"] = {
function() Snacks.terminal(nil, { win = { position = "float" } }) end,
desc = "Toggle Terminal Float",
}
Wish one day Snacks can be part of the core and replaces a ton of core plugins.
They don't really provide much and I'm not a fan of the structure personally. They also aren't super full featured and aren't particularly good replacements for the masses
yeah i have mixed feelings too, i like the dashboard and the lazygit with nicer colors. the issue is that many of the stuff needs configuration and people should configure it themself instead of a oppionated version in astrocommunity
Also lazygit nice colors had been implemented similarly into AstroUI
If we are splitting them into individual plugins, would adding a pack for snacks be handy to enable them all?
@ALameLlama yeah this is what I imagined would be the case
I'd like to know what stage it's at now.
I'd like to know what stage it's at now.
This PR is still in draft. There are lots of plugins from snacks.nvim still missing.
I'd like to know what stage it's at now.
This PR is still in draft. There are lots of plugins from snacks.nvim still missing.
Thank you very much
since v5 is launched, this seems like its not needed. Wdyt? @luxus @mehalter cc @AstroNvim/astrocommunity-maintainers
I think there are still some good stuff in here that are useful like if the user wants to easily opt into the snacks.words or snacks.statuscol