astrocommunity icon indicating copy to clipboard operation
astrocommunity copied to clipboard

feat(pack): add an NvChad UI pack

Open mehalter opened this issue 1 year ago • 2 comments

📑 Description

Add a pack for integrating the NvChad UI toolkit in AstroNvim

ℹ Additional Information

mehalter avatar Oct 03 '24 16:10 mehalter

Review Checklist

Does this PR follow the [Contribution Guidelines](development guidelines)? Following is a partial checklist:

Proper conventional commit scoping:

  • If you are adding a new plugin, the scope would be the name of the category it is being added into. ex. feat(utility): added noice.nvim plugin

  • If you are modifying a pre-existing plugin or pack, the scope would be the name of the plugin folder. ex. fix(noice-nvim): fix LSP handler error

  • [x] Pull request title has the appropriate conventional commit type and scope where the scope is the name of the pre-existing directory in the project as described above

  • [x] README is properly formatted and uses fenced in links with <url> unless they are inside a [title](url)

  • [x] Entry returns a single plugin spec with the new plugin as the only top level spec (not applicable for recipes or packs).

  • [x] Proper usage of opts table rather than setting things up with the config function.

  • [x] Proper usage of specs table for all specs that are not dependencies of a given plugin (not applicable for recipes or packs).

github-actions[bot] avatar Oct 03 '24 16:10 github-actions[bot]

wolf in sheep's clothing

luxus avatar Oct 03 '24 16:10 luxus

Whats blocking this PR?

Uzaaft avatar Oct 04 '24 07:10 Uzaaft

@Uzaaft NvChad/ui doesn't currently actually support loading configuration like this. So it doesn't fully work. Once that gets added (if it does) then I can test this more and add the rest of the missing stuff like leybindings and whatnot

mehalter avatar Oct 04 '24 11:10 mehalter

@Uzaaft I opened some PRs upstream to add the missing support and now this PR works great!

mehalter avatar Oct 04 '24 13:10 mehalter

Fuck it, ship it

Uzaaft avatar Oct 04 '24 17:10 Uzaaft