AstroChart
AstroChart copied to clipboard
Conjunction aspect is not drawn
Describe the bug In the aspects settings there's a configuration for conjunction aspect: https://github.com/AstroDraw/AstroChart/blob/main/project/src/settings.js#L170 , but even when I've changed the color from transparent to some other color I still don't see any changes in the chart.
To Reproduce Steps to reproduce the behavior:
- Change the color from transparent to some other color in the settings of conjunction aspect
- Make sure that conjunction aspect should exist according to the data you're passing
- Refresh the chart and check it
Expected behavior Conjunction aspect should be displayed visually somehow. Here are the examples from other astrology chart apps:
Screenshots N/A
Additional info (please complete the following information):
- Browser [e.g. chrome, safari] Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/105.0.0.0 Safari/537.36
Additional context N/A
I take a look and seems that we have 2 bugs:
- the function
hasAspect
is not calculating correctly for some cases, when is conjunction; - when it calculates correctly the conjunction aspect, it is not showing because the aspects are under the chart and also because the conjunction is drawn in the same place that the inner circle. I changed the order in the html directly to check:
This would take more time to resolve, since I need to check the best way to show the conjunction. Feel free to contribute with your suggestion, or solving the hasAspect
bug.