Messenger-CLI icon indicating copy to clipboard operation
Messenger-CLI copied to clipboard

Published 20 hours ago • verified publisher icon AstroCB

Sound notification on new message

Open dpriskorn opened this issue 5 years ago • 3 comments

Hi again. I found https://www.npmjs.com/package/mpg123 And http://soundbible.com/2218-Service-Bell-Help.html I will try adding that to the script. Would you accept a pull request adding sound notification? It would probably be preferable to have a switch to turn it of in the top of the file also. WDYT?

dpriskorn avatar Aug 10 '20 03:08 dpriskorn

You're welcome to make those changes in your local copy or a fork, but I'm not too keen on merging that type of thing into the repo since it seems like it could get a little disruptive as default behavior, and it also looks like the dependency has been deprecated.

At the very least I think it'd make more sense for sounds to be off by default, and maybe toggled on with a command.

AstroCB avatar Aug 10 '20 03:08 AstroCB

Off by default was my intention. What about https://www.npmjs.com/package/speaker which seems updated an in more use, is that acceptable?

dpriskorn avatar Aug 10 '20 03:08 dpriskorn

Yep, that one looks like a better bet to me.

AstroCB avatar Aug 10 '20 22:08 AstroCB