binaryen.js icon indicating copy to clipboard operation
binaryen.js copied to clipboard

Comment on Binaryen proposal

Open ericvergnaud opened this issue 1 year ago • 2 comments

Hi there,

to avoid observed gaps between the TypeScript in this repo and the underlying JavaScript in Binaryen repo, I have submitted a PR that moves the TypeScript source to the Binaryen repo and generates the JavaScript from it, thus ensuring a single source of truth.

The PR is here https://github.com/WebAssembly/binaryen/pull/6192. (If approved, that PR would be followed by a corresponding PR in this repo, adjusting for the change of source of truth for TypeScript)

It would be great if you could comment on that PR rapidly such that the Binaryen team can reach a decision on whether or not to accept the PR.

ericvergnaud avatar Jan 09 '24 19:01 ericvergnaud

I do like the idea of replacing the JS plus separate typings with TS plus generated typings. I'd probably go even further and also generate the API docs from tsc's type info and respective comments while on it. Or even further, and generate all of it while also guaranteeing that the C++, C and JS APIs are in sync.

dcodeIO avatar Jan 14 '24 19:01 dcodeIO

Following a counter PR https://github.com/WebAssembly/binaryen/pull/6224, I've opened a discussion here: https://github.com/WebAssembly/binaryen/discussions/6225

ericvergnaud avatar Jan 14 '24 22:01 ericvergnaud