binaryen.js icon indicating copy to clipboard operation
binaryen.js copied to clipboard

commonjs

Open dvtate opened this issue 2 years ago • 6 comments

I have no idea when or why this package became an esm-only project but it should definitely offer both module systems or create a separate packages as converting my entire project over to esm has come with some new painpoints

dvtate avatar Jun 16 '22 02:06 dvtate

Also I feel like this is a more substantial breaking change an have no idea when it occured between v99.0.0 and v109.0.0... really I feel like this semver sysytem isn't right either

dvtate avatar Jun 16 '22 02:06 dvtate

Also I feel like this is a more substantial breaking change an have no idea when it occured between v99.0.0 and v109.0.0... really I feel like this semver sysytem isn't right either

This just wrapper of native binaryen and version synced with native's version.

MaxGraey avatar Jun 16 '22 05:06 MaxGraey

the native's version is not v109.0.0 it's version_109

dvtate avatar Jun 16 '22 15:06 dvtate

the native's version is not v109.0.0 it's version_109

That's right. They have the same major versions. I don't see any inconsistency here

MaxGraey avatar Jun 16 '22 16:06 MaxGraey

Just the 2 wasted subversions... Regardless, this is besides the point of breaking module compatibility. You can look at yargs for example of a package which supports both esm and commonjs

dvtate avatar Jun 16 '22 17:06 dvtate

I stumbled onto this as well. CommonJS builds should definitely be included...

judehunter avatar Aug 07 '22 13:08 judehunter