assemblyscript icon indicating copy to clipboard operation
assemblyscript copied to clipboard

Add missed tests for SIMD with usize and isize type

Open JesseCodeBones opened this issue 1 year ago • 4 comments

Hi Maintainer,

I found there is no tests for v128 with type usize and isize, I will prepare a PR for that. please let me know if the tests are suitable or if I missed anything.

Regards

JesseCodeBones avatar Aug 25 '22 08:08 JesseCodeBones

I'm not sure using isize / usize parameter types for SIMD was a good idea. Some wasm ops may return different results in wasm32 / 64 mode. Like v128.bitmask<usize>(...) will be not the same result.

I more prefer to remove support of isize / usize for polymorphic methods of v128. @dcodeIO wdyt?

MaxGraey avatar Aug 25 '22 09:08 MaxGraey

@MaxGraey True, I added the condition if (process.arch == "wasm64") to figure out if it is wasm64

JesseCodeBones avatar Aug 25 '22 09:08 JesseCodeBones

if these type need to be removed from SIMD feature, should we add /** @deprecated */ for these function signature firstly, as this kind of signatures already are apart of public APIs? WDYT?

JesseCodeBones avatar Aug 27 '22 03:08 JesseCodeBones

Related with PR 2491.

JesseCodeBones avatar Sep 02 '22 01:09 JesseCodeBones