assemblyscript
assemblyscript copied to clipboard
Uses short names for buitlin types for diagnostics and bindings
Instead internat ~lib/string/String
or ~lib/string/Array<i32>
this PR simplify such names to string
and Array<i32>
- [x] I've read the contributing guidelines
- [x] I've added my name and email to the NOTICE file
One way to think about this could be that global elements have a second internal name, e.g. ~lib/string/String
can also be looked up internally with just String
. So by convention, if an element is in global scope, the short name could be used. This however differs slightly from what the PR does (looks a ~lib/
even if an element is not global) - perhaps change?
So by convention, if an element is in global scope, the short name could be used. This however differs slightly from what the PR does (looks a ~lib/ even if an element is not global) - perhaps change?
Hmm, interesting. But how I can check is this element global easily?
Hmm, perhaps a check that elementsByName.get(theShortName)
exists, i.e. that the assumption that the short name can be used holds.
This PR has been automatically marked as stale because it has not had recent activity. It will be closed in one week if no further activity occurs. Thank you for your contributions!
This PR has been automatically closed due to lack of recent activity, but feel free to reopen it as long as you merge in the main branch afterwards.