assemblyscript icon indicating copy to clipboard operation
assemblyscript copied to clipboard

Closures: Added tests from the current closures PR

Open torch2424 opened this issue 5 years ago • 3 comments

relates to #1308 relates to https://github.com/AssemblyScript/working-group/issues/41

As discussed in the working group meeting, this moves the Tests that are being added / modified in the current AssemblyScript Closures PR #1308 , and skips the relevant errors in these closures tests. This is being done, as these tests represent our current goals of what closures should support, while also, allowing us to start bringing closures into main/master in smaller more manageable PRs :smile:

NOTE: Closures will need additional tests later down the line. But again, just trying to start merging in what we currently have in parts that won't affect the project as a whole or break things :smile:

cc @DuncanUszkay1 :smile:

Screenshots

Screenshot from 2020-07-15 17-41-40 Screenshot from 2020-07-15 17-39-36

torch2424 avatar Jul 16 '20 00:07 torch2424

@dcodeIO @DuncanUszkay1 This should be good to go now! Tests are passing and everything :smile: :+1:

torch2424 avatar Jul 20 '20 20:07 torch2424

Thanks Aaron! Suggesting to leave this PR open until we have an implementation to test positive against. Still good to have these tests pinned here so we know what we are looking for initially :)

dcodeIO avatar Jul 21 '20 09:07 dcodeIO

@dcodeIO You are welcome! :smile:

Suggesting to leave this PR open until we have an implementation to test positive against. Still good to have these tests pinned here so we know what we are looking for initially :)

So normally I would agree, but since the PR is going to be really really large. I think it'd probably good to merge these, and then unskip / update them in our final closures PR? If you are worried that people will think that closures will work, I can add a note comment on the top of the file? :smile:

I also think this method would be a better, that way we can implement closures themselves in smaller pieces and get tests passing one or a couple at a time :smile:

Unless you would prefer to just merge it in an all-in-one PR?

torch2424 avatar Jul 21 '20 18:07 torch2424