Alex Sharov
Alex Sharov
@gdevanla what is your version?
there is `RLock`: ``` me.t.mu.RLock() wantPeers := me.t.wantPeersEvent.C() me.t.mu.RUnlock() ``` but method `C` does lazy mutation: ``` if me.ch == nil { me.ch = make(chan struct{}) } ```
@lystopad do we need it?
@stan-dot - or create PR with description - why we need it, what are plans to use it in future, what real problem it solving, etc...
`github.com/erigontech/erigon-libekv` -> `github.com/erigontech/erigon-lib/kv`
seems implemented in https://github.com/erigontech/interfaces/pull/245
@wmitsuda FYI: maybe next commands may help to test files `erigon snapshots integrity --check=InvertedIndex` and `erigon snapshots integrity --check=HistoryNoSystemTxs`
Commitment is not enough determenistic. - it’s known issue. other things - i’m not sure, but probably ok to ignore.
commitment .kvei and .kvi - is index of .kv - also expected to be different
If your PR changing .ef then .efi will also changed