Ashwin Kulkarni
Ashwin Kulkarni
@Dev79844 Please pull the latest from master which has linter version 1.60.1 that will fix the linter issue. Thanks
@JyotinderSingh For this, while pushing onto the stack, shall we also add a reference? https://github.com/DiceDB/dice/blob/master/core/eval.go#L978
The cleanup method looks good. @kushal0511-not (just an overhead of popping and again pushing almost full array everytime) Also, I agree with what @soumya-codes says, stack-length and actual stack operations...
@JyotinderSingh Please assign this issue to me and @gauravsarma1992
@JyotinderSingh Please assign it to @gauravsarma1992 and me
Closing this as not a priority!
@lucifercr07 Please check the linter warnings. You can easily fix them. Thanks
@lucifercr07 ^^
I second @gauravsarma1992 . We can have a separate package to handle the store object in the internal folder. Also, There can be a separate interface that can be implemented...
@soumya-codes let me also know if possible when you guys are discussing. Want to hear your thoughts on this.