Ashutosh Kasudhan comments

Results 35 comments of


                                            Ashutosh Kasudhan

Implement validation job for prod models inheriting from base models

Sure @ankita240796 here is the list of checks done in domain object of classroom model: - Name validation of classroom. - Teaser text validation. - Topic list intro validation. -...

Implement validation job for prod models inheriting from base models

Got it @ankita240796 i.e I need to fill table present in the doc for all listed models in both associated issues, and hence attach it to GSoC proposal. Right ?

Implement validation job for prod models inheriting from base models

@ankita240796 here is that table for `ClassroomModel`, I can't think validation job for other than model id, as each attribute could be validated in domain layer. ![Image](https://github.com/user-attachments/assets/e9377747-e560-4a26-b33f-9022ad9b1724) Now the parts...

Implement validation job for prod models inheriting from base models

@ankita240796 here is link of complete [doc](). Pls refer to classroomModel for this time coz it is under process right now. - Yeah this model has relation with topic model,...

Implement validation job for prod models inheriting from base models

Thanks @ankita240796 for all replies, everything LGTM now. Tasks for me: - Add validate method for ImageData, and hence update existing methods to use this new method for validating Imagedata...

Implement validation job for prod models inheriting from base models

Fine @ankita240796 I'll open a new one. Edit: I think let's do that when I complete design doc, as it helps to find more such cases.

Implement missing domain objects with full `validate()` function.

Hi @ankita240796 I would like to pick EmailModels, below are suggestions for validation logic as seen in respective models, they follow this format of explaining `attribute: type and Validation logic....

Implement missing domain objects with full `validate()` function.

Hi @ankita240796 I implemented domain object and validation for `ExplorationVoiceArtistsLinkModel`. ### Domain Object ``` exp_id: It is the id of exploration for which a new model will be created. content_id_to_voiceovers_mapping:...

Implement missing domain objects with full `validate()` function.

Hi @ankita240796 thanks for responding, here are replies to your comments for both SentEmailModel and BulkEmailModel. 1. `Valid Email Address`: For both the models, valid email would have these characteristics:...

[CI Failure]: FileNotFoundError: [Errno 2] No such file or directory: '/home/runner/work/oppia/oppia/node_modules/.yarn-integrity'

Similar issue occurred two times with merge queue on this [PR](https://github.com/oppia/oppia/pull/22249). Here is the error log: Second iteration: See the failure [here](https://github.com/oppia/oppia/actions/runs/14164190378/job/39674496811). ``` FAIL: test_incomplete_overall_backend_coverage_throws_error (scripts.run_backend_tests_test.RunBackendTestsTests) ---------------------------------------------------------------------- subprocess.CalledProcessError: Command '['yarn',...