BottomNavigation icon indicating copy to clipboard operation
BottomNavigation copied to clipboard

Text is too high up for bottom bar

Open jt-gilkeson opened this issue 7 years ago • 1 comments

The guidelines call for the text to be aligned at the bottom with 10dp underneath. This library has the bottom of the text higher than that (like 13 dp)

https://material.io/guidelines/components/bottom-navigation.html#bottom-navigation-specs

If you look at the guidelines the bottom of the text is exactly aligned at 10dp. But in the library if I change the bottom padding to 0, you'll see that there is still some padding (probably built in to TextView) above the bottom of the screen (which explains the discrepancy).

The problem with this is that the text is too high and the icons will not have a gap between them and the top of the text if you use the full 24x24. Also the spacing below the text looks awkwardly larger than it should be.

If you take a screen shot of the google photos app and compare its bottombar to this library - you will see the spacing issue.

Something needs to be changed with the padding at the bottom to compensate for the textview's built in padding.

Through tweaking things it looks like bottom padding of 7dp makes the bottom of the text line up correctly at 10dp

jt-gilkeson avatar Aug 02 '17 22:08 jt-gilkeson

I think thats it's due to TextView in Built Padding. I will have a look at it

Ashok-Varma avatar Aug 03 '17 10:08 Ashok-Varma

106/5000 Hi,bro. Wǒ kěyǐ tíchū yīgè xiǎo jiànyì, zhīchí textview jí Title(wénzì) yǔ icon(túbiāo) zhī jiān de jùlí shèzhì hé BottomNavigationbar de gāodù zì dìngyì shèzhì rúhé? Wǒ juédé zhèyàng zi huì gèng línghuó yīdiǎn, gèng ràng rén xǐ'ài? hi, bro. I can make a small suggestion that supports the textview and Title (text) and icon (icon) distance settings And BottomNavigationbar height customization settings how? I think this will be more flexible, more people like it? @Ashok-Varma

dosicker avatar Jan 05 '18 01:01 dosicker