audio-only-youtube icon indicating copy to clipboard operation
audio-only-youtube copied to clipboard

Published 20 hours ago • verified publisher icon Ashish-Bansal

Refactoring background.js

Open sheldonled opened this issue 6 years ago • 6 comments

I refactored background.js to make the extension support enabling/disabling per tab. This closes issue #3

sheldonled avatar Oct 16 '17 14:10 sheldonled

@sheldonled Thanks but I couldn't get it to working. Is it working fine in your local environment ?

Ashish-Bansal avatar Oct 20 '17 16:10 Ashish-Bansal

Hey @Ashish-Bansal, I think I might have found the issue. Sent another commit to this PR, please take a look at it.

cheers

sheldonled avatar Oct 21 '17 11:10 sheldonled

@sheldonled First of all, Thanks a lot for code cleanup! I really appreciate that. When I created this extension, I was a C++ guy ;)

I works as expected but I don't want to remove the previous behaviour too. Instead I would like to have enable/disable per tab as optional feature which gets (de)/activated through context menus ?

And sorry for late reply!

Ashish-Bansal avatar Nov 10 '17 14:11 Ashish-Bansal

@Ashish-Bansal We should close it now.

Kompwu avatar Jul 16 '18 00:07 Kompwu

@Kompwu There was one feature in this PR which still needs to be ported. That's why I haven't closed it.

Ashish-Bansal avatar Jul 16 '18 07:07 Ashish-Bansal

@Ashish-Bansal individual toggle per tab?

Kompwu avatar Jul 16 '18 08:07 Kompwu