large screen support (WIP)

[abcghy]

issue: #338

Guideline: https://developer.android.com/jetpack/compose/layouts/adaptive Official Reference: https://github.com/android/compose-samples/tree/main/JetNews Design Reference: https://m3.material.io/foundations/layout/canonical-layouts/list-detail

[JunkFood02]

FYI: Compose Material3 Adaptive Version

[Ashinch]

Maybe we can wait for #502 to be merged before we start this work?

At present, the compose version on the main branch is far behind.

Or create a dev branch for experimental functions based on #502.

I'm not sure when 0.9.12 will be released. There are still some problems with Google Reader API integration. I'm worried that #502 will wait too long, so that the new features will not be start.

[mbestavros]

@Ashinch If delaying @JunkFood02's Compose update (#502) is holding community development back, why not merge it now? Especially if Greader needs a bit more time to cook as well.

[Ashinch]

@Ashinch If delaying @JunkFood02's Compose update (#502) is holding community development back, why not merge it now? Especially if Greader needs a bit more time to cook as well.

Hi, @mbestavros

Google Reader API does indeed need some improvement time. Do you have any suggestions? For example, creating a new dev branch to merge these PRs, allowing the new PRs to continue development using the dev branch，after stabilizing, merge the dev branch back into the main branch? 🤔

[Ashinch]

@Ashinch If delaying @JunkFood02's Compose update (#502) is holding community development back, why not merge it now? Especially if Greader needs a bit more time to cook as well.

Hi, @mbestavros

Google Reader API does indeed need some improvement time. Do you have any suggestions? For example, creating a new dev branch to merge these PRs, allowing the new PRs to continue development using the dev branch，after stabilizing, merge the dev branch back into the main branch? 🤔

The reason for blocking #502 is that it involves a significant dependency upgrade, and I'm not sure if the UI will work properly. Currently, I'm dealing with issues related to the Google Reader API, so I might not have time to migrate the changes brought by #502.

[JunkFood02]

not sure if the UI will work properly

Have been using the app with latest Compose for a while (not much!), and I didn't see any noticeable glitch or bug in it. To be honest, since stable release (v1.0) is still far ahead, users should be more open to help test potential issues as long as there're still updates and fixes

[Ashinch]

Hi, @abcghy

Could you please help resolve a code conflict? I think some of our infrastructure is now ready.

[Ashinch]

Hi, everyone.

What is the current status of this PR?

Has anyone else tried it yet?

I want to know if it can be merged. ☺️

[JunkFood02]

I've just reviewed this implementation before. It's a rather simple walkaround for large screen support, but lack of handling many corner cases, like rotating the screen or system navigation. Anyway, existing users(compact screen width) shouldn't be affected by this change, so I'm approving it

[Ashinch]

Okay, please remind me when this PR is ready.

[abcghy]

1. added isArticleOpen and articleId in HomeUiState.
2. Combine Reading Page with Flow Page into FlowRoute. So that we can determine which page to show according to screen width and isArticleOpen.
3. Removed Reading Page from navigation due the reason above.

@JunkFood02

[JunkFood02]

Finally Google has stabilized their large screen support library! We can begin to leverage material3-adaptive in our app now

References: https://www.youtube.com/watch?v=wBc6oMVAP60 https://developer.android.com/reference/kotlin/androidx/compose/material3/adaptive/package-summary https://android-developers.googleblog.com/2024/05/get-big-picture-with-large-screens-at-google-io-24.html https://www.youtube.com/watch?v=G-76xfNlMxc https://www.youtube.com/watch?v=xPUZENis4gc