Burrito
Burrito copied to clipboard
XML parsing not working properly for Tekkits EOD markers
While I have not tested it yet on windows, something leads me to believe that this is not how the markers are supposed to look.
It creates an extra line from the center of the map to every zipline point.
Is this using the embedded XML parser or is this using the conversion script?
I was loading the XML file directly from the "Open Markers File" dialog.
This seems to be caused by some trails using [0,0,0] as some kind of "null terminator" (see https://github.com/coderedart/jokolay/releases/tag/v0.2.2).
Trails have multiple sections within the same trl
binary file.
[1, 1, 1]
[2, 2, 2]
[3, 3, 3]
[0, 0, 0]
[2, 2, 2]
[1, 5, 3]
Treat [0, 0, 0]
as a special null terminator that separates trail sections. So, the first 3 nodes and the last 2 nodes are separate trail sections, which must not be connected in anyway. I was really surprised to find that out :rofl:
Ah drat, I could have been more informative in my original question. We actually handled this in the manual converter step. https://github.com/AsherGlick/Burrito/blob/02fc3afaead1a6b3d5d7e75364d3614125b88b15/scripts/taco_to_burrito.py#L278-L282
I guess it was not handled properly in the rust xml parser. That parser is going away soon anyways and we are handling it properly in the new one.