Pull requests actions
Triggers
- [x] Opened PR
- [x] Opened PR from fork
- [x] Comment❓❓
- Anyone could comment to trigger this action
- When PR is updated, then anyone could comment something like:
/verifyto trigger action again
- [ ] Cleanup
Test-PRFilefunction- [ ] Export checks into own funciton with $status, $manfiestOb, $manifestGci
Checks
- [x] Description
- [ ] License (Add note to children list, about what is wrong)
- License property exists, but it is not valid SPDX identifier
- [x] Hashes
- [x] Checkver
- [x] Autoupdate
- [ ] Install (#59)
- [ ] Format (#24)
Expected comment:
Thanks for contributing. Your PR did not pass requirements.
### Manifest 1
- [x] Description
- [ ] License
- [x] Hashes
- [x] Checkver
- [x] Autoupdate
### Manifest 2
- [x] Description
- [x] License
- [x] Hashes
- [x] Checkver
- [x] Autoupdate
Thanks for contributing. PR looks good.
Wait for review from human collaborators.
Implementation:
Best possible to temporary save into some hashtable:
@{name = 'Manifest1'; 'Checkver' = Passed; 'Properties': 'OK | list of failed properties'}
~~Rework test-hash function to be reusable.~~
There is no need to do it this hard way. Keep it capturing streams and wait for binaries rework
~~Resolve how to run tests in context of pull request files~~
DONE
~~Try PR from forked repository~~
DONE
~~Basic implementation is done.~~
~~Now comes more problematic things:~~
~~- Install check~~ ~~- Format check~~
Issue description
~~When invoking from forked repository, context is on current repository not forked.~~
~~Investigate how to do it with push event~~
Rather do it with custom cloning forked repository
~~Add more license checks:~~
~~- [x] If property exists~~ ~~- [ ] If it is valid spdx identifier~~ ~~- [ ] No? Is there URL?~~
~~md~~ ~~- [ ] License~~ ~~- [ ] Valid SPDX Identifier~~ ~~- [ ] Invalid + URL~~ ~~~~
~~This will require adding $Indent switch to create-new-checklist function~~
#21
~~Add note about log:~~
~~Please see run log for pure result of all checks~~
Forked repositories are now covered and working.
Pull request comments with /verify are handled
For first release this is enough.
Install and format will come in future versions