Scoop-GithubActions icon indicating copy to clipboard operation
Scoop-GithubActions copied to clipboard

Pull requests actions

Open Ash258 opened this issue 6 years ago • 10 comments

Triggers

  • [x] Opened PR
  • [x] Opened PR from fork
  • [x] Comment❓❓
    • Anyone could comment to trigger this action
    • When PR is updated, then anyone could comment something like: /verify to trigger action again
  • [ ] Cleanup Test-PRFile function
    • [ ] Export checks into own funciton with $status, $manfiestOb, $manifestGci

Checks

  1. [x] Description
  2. [ ] License (Add note to children list, about what is wrong)
    • License property exists, but it is not valid SPDX identifier
  3. [x] Hashes
  4. [x] Checkver
  5. [x] Autoupdate
  6. [ ] Install (#59)
  7. [ ] Format (#24)

Expected comment:

Thanks for contributing. Your PR did not pass requirements.

### Manifest 1

- [x] Description
- [ ] License
- [x] Hashes
- [x] Checkver
- [x] Autoupdate

### Manifest 2

- [x] Description
- [x] License
- [x] Hashes
- [x] Checkver
- [x] Autoupdate

Thanks for contributing. PR looks good.

Wait for review from human collaborators.

Implementation:

Best possible to temporary save into some hashtable:

@{name = 'Manifest1'; 'Checkver' = Passed; 'Properties': 'OK | list of failed properties'}

Ash258 avatar Jun 25 '19 07:06 Ash258

~~Rework test-hash function to be reusable.~~

There is no need to do it this hard way. Keep it capturing streams and wait for binaries rework

Ash258 avatar Jun 26 '19 17:06 Ash258

~~Resolve how to run tests in context of pull request files~~

DONE

Ash258 avatar Jun 26 '19 18:06 Ash258

~~Try PR from forked repository~~

DONE

Ash258 avatar Jun 26 '19 18:06 Ash258

~~Basic implementation is done.~~

~~Now comes more problematic things:~~

~~- Install check~~ ~~- Format check~~

Issue description

Ash258 avatar Jun 26 '19 20:06 Ash258

~~When invoking from forked repository, context is on current repository not forked.~~

~~Investigate how to do it with push event~~

Rather do it with custom cloning forked repository

Ash258 avatar Jun 28 '19 07:06 Ash258

~~Add more license checks:~~

~~- [x] If property exists~~ ~~- [ ] If it is valid spdx identifier~~ ~~- [ ] No? Is there URL?~~

~~md~~ ~~- [ ] License~~ ~~- [ ] Valid SPDX Identifier~~ ~~- [ ] Invalid + URL~~ ~~~~

~~This will require adding $Indent switch to create-new-checklist function~~

#21

Ash258 avatar Jun 28 '19 08:06 Ash258

~~Add note about log:~~

~~Please see run log for pure result of all checks~~

Ash258 avatar Jun 28 '19 09:06 Ash258

Forked repositories are now covered and working.

Ash258 avatar Jul 06 '19 18:07 Ash258

Pull request comments with /verify are handled

Ash258 avatar Jul 07 '19 09:07 Ash258

For first release this is enough.

Install and format will come in future versions

Ash258 avatar Jul 07 '19 10:07 Ash258