asgaros-forum icon indicating copy to clipboard operation
asgaros-forum copied to clipboard

Change in the 'show_history()' function

Open pilinski opened this issue 5 years ago • 2 comments

Hello,

I would like to propose the change in the show_history() function definition: the section responsible for printing the table I would extract to the public function show_user_history($user_id)

Advantages:

  1. the code of 'show_history' looks more comprehensive and clean
  2. no need to change any other code
  3. code of 'show_user_history' can help (in the future) to solve issues like:
    https://www.asgaros.de/support/topic/ultimate-member/?part=3#postid-4409

Kind regards, Maciej

pilinski avatar Dec 27 '19 08:12 pilinski

Hello Thomas,

could you please do me a favour and merge also these two commits. One fixes a minor bug, second makes the code more clean and gives the new 'show_user_history' function. Very simple commits.

Kind regards, Maciej @pilinski

pilinski avatar Mar 03 '21 21:03 pilinski

Hi @pilinski

Dont worry, it will be included as well. I just have to re-arrange it a little bit with another PR.

Greetings, Thomas

Asgaros avatar Mar 04 '21 01:03 Asgaros