asgaros-forum
asgaros-forum copied to clipboard
Change in the 'show_history()' function
Hello,
I would like to propose the change in the show_history()
function definition: the section responsible for printing the table I would extract to the public function show_user_history($user_id)
Advantages:
- the code of 'show_history' looks more comprehensive and clean
- no need to change any other code
- code of 'show_user_history' can help (in the future) to solve issues like:
https://www.asgaros.de/support/topic/ultimate-member/?part=3#postid-4409
Kind regards, Maciej
Hello Thomas,
could you please do me a favour and merge also these two commits. One fixes a minor bug, second makes the code more clean and gives the new 'show_user_history' function. Very simple commits.
Kind regards, Maciej @pilinski
Hi @pilinski
Dont worry, it will be included as well. I just have to re-arrange it a little bit with another PR.
Greetings, Thomas