AsBuiltReport.VMware.vSphere icon indicating copy to clipboard operation
AsBuiltReport.VMware.vSphere copied to clipboard

Published 20 hours ago • verified publisher icon AsBuiltReport

Add translation functionality

Open baukeplugge opened this issue 1 year ago • 3 comments
trafficstars

Added 2 functions to add translation strings to all user visible text. (not all text has been replaced by function yet)

Description

Added 2 functions:

  • Load-translations
  • Get-Translation these functions will read language files from the language directory. The language will be set in the config file.

Related Issue

Motivation and Context

With this change the users will be able to generate reports in different languages. Extra languages can be added.

How Has This Been Tested?

I have run this change on my laptop running powershell 5.1.22621.3958. generated dutch and english reports.

Screenshots (if appropriate):

Types of changes

  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [x ] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • [x] My code follows the code style of this project.
  • [x] My change requires a change to the documentation. (language option)
  • [ ] I have updated the documentation accordingly.
  • [ ] I have read the CONTRIBUTING document.

baukeplugge avatar Sep 18 '24 13:09 baukeplugge

Thanks for your PR @baukeplugge. I like this 👍 , but I would like to investigate how we could incorporate this into the AsBuiltReport Core module so that we can use this in all reports. This is a feature which has been requested by others but it may prove more difficult to introduce in other reports. Lets continue the discussion here.

tpcarman avatar Sep 18 '24 23:09 tpcarman

Thanks for your PR @baukeplugge. I like this 👍 , but I would like to investigate how we could incorporate this into the AsBuiltReport Core module so that we can use this in all reports. This is a feature which has been requested by others but it may prove more difficult to introduce in other reports. Lets continue the discussion here.

Hi Tim,

I thought of the core aswell, that would be the better place indeed. I was not able to join the discussion you linked in your post.

kind regards Bauke

baukeplugge avatar Sep 19 '24 07:09 baukeplugge

Please try the discussion link again. It seems I had not setup discussions for the organisation correctly.

tpcarman avatar Sep 19 '24 12:09 tpcarman

Closing this PR as the functionality is under review for adoption across all report modules. Further updates can be found in the discussion thread.

tpcarman avatar Aug 29 '25 02:08 tpcarman