zig-protobuf icon indicating copy to clipboard operation
zig-protobuf copied to clipboard

Manage errors at decoding

Open Arwalk opened this issue 4 years ago • 2 comments

There is currently no check on the validity of the values (as in, varint decoded is bigger than actually possible to fit in the struct)

Need to do this for any kind of varint.

Impact on decode_varint (if it doesnt fit, return error) and on the transformation done to fit the final structure in pb_decode

Arwalk avatar May 25 '21 08:05 Arwalk

Wiredecoder should check for the fully encoded tag, which would eliminate errors in wirevalues naturally.

Arwalk avatar Aug 02 '21 13:08 Arwalk

Wiredecoder should check for the fully encoded tag, which would eliminate errors in wirevalues naturally.

Done indirectly with acb2a57c1612a3fb096efc383ac1b3ffa8548d93

Arwalk avatar Aug 18 '21 22:08 Arwalk