PaimonTray icon indicating copy to clipboard operation
PaimonTray copied to clipboard

Display completed weekly boss discounts rather than remaining

Open skywardpixel opened this issue 2 years ago • 1 comments

Should we consider inverting the weekly boss counter? Currently the app displays remaining discounts (0/3 = completed), but it might make more sense to show completed discounts instead (3/3 = completed) to be consistent with the daily quest counter (4/4 being completed).

For reference, Paimon tray apps on other platforms display the two counters consistently:

  • daidr/paimon-webext shows both daily quests completed and weekly bosses completed: https://github.com/daidr/paimon-webext/blob/12aa1f52fa3d1956cc102a5115179d2ec7a39256/src/popup/Popup.vue#L258-L259
  • spencerwooo/PaimonMenuBar shows both daily commissions left and weekly boss discounts left: https://github.com/spencerwooo/PaimonMenuBar/blob/1a0ac69f66a55cbf89a3d2a8e066a874621a0aba/PaimonMenuBar/MenuExtrasView.swift#L254

Happy to send a PR if this sounds reasonable.

skywardpixel avatar Jan 08 '23 19:01 skywardpixel

The idea of consistency: accepted. Completed rather than remaining: rejected.

At the very dawn of PaimonTray, it was developed just to taste WinUI 3, and I used to reckon that it would last no longer than 3 months. That's why I code in a casual style and follow the 米游社/HoYoLAB UI patterns for the real-time notes introducing inconsistency. I would like to let you know that making the real-time note data show in a consistent way has already been considered a TODO task as a part of refactoring UI display modes after some other necessary work. The planned consistent way is "remaining rather than completed" for not only daily commissions and weekly bosses but also others.

ArvinZJC avatar Jan 09 '23 11:01 ArvinZJC