Arthur McGibbon

Results 87 comments of Arthur McGibbon

@som-snytt That's handy thanks. I can see why it's not on by default - lots of false positives.

@tgodzik > Wow! This looks awesome! This could replace the packages view in Metals tree view if I understand correctly? Does this show up in the file explorer? Yes -...

@kpodsiad >After looking at https://marketplace.visualstudio.com/items?itemName=sourcegraph.sourcegraph and https://github.com/olafurpg/sourcegraph-vscode/blob/diffs-view/src/file-system/FilesTreeDataProvider.ts it seems like we could replace Metals tree view and have breadcrumbs without adding a new workspace folder. Having a custom tree view...

Changing from a flat file structure to a real representation of where the jars are located doesn't look great... ![image](https://user-images.githubusercontent.com/5612295/159694806-8bd4efdc-ba38-4b92-a7a8-7950b90376e8.png)

I'm going to close this since the way the FileSystem API makes the tree UI exactly reflect the URI makes it unworkable for the way Metals wants to use URIs...

@tgodzik I closed this because I couldn't see an easy way to match off the 2 different URI formats (i.e. the one Metals uses to identify classes in jars and...

@tgodzik No worries - glad you've had a break. I haven't been able to think of another option so I've gone ahead with a `MetalsFileSystem/MetalsFileSystemProvider/MetalsPath` and it seems to work...

I think this is now almost functionally complete. There's a lot of code I need to tidy and many tests to write but it would be good to get some...

@tgodzik When you have a moment - could you have a look through this and see whether you're happy with the approach regarding custom java filesystem and custom url handler....

> * each time I open a workspace I get an error > ![image](https://user-images.githubusercontent.com/3807253/167106867-5b258770-9580-4d0f-9234-0b8a475af562.png) > maybe we could create the additional filesystem only after indexing? I think currently we send...