Arthur

Results 795 comments of Arthur

Okay! Now fixing this should only need `make fixup`. But to make sure you have the correct black version run `pip install -e .` should do the trick. Once you...

Sorry for the delay, went in holidays. This seems like a big modification, so I think having performance stats would be better before merging (this adds a layer of complexity...

Great job working on this! Can you run `make style` and make sure you rebase on main first? We recently merged a huge PR related to the code styling! See...

Feel free to ping me once you are done adressing all the previous comments and want another review 😉

Awesome thanks for the review 🤗

yes! Hahah sorry, maybe next week or 2 weeks from now !

Okay! Thanks to @gante's recommendations, the xla generation works perfectly! The slow timestamp processing test also passes 🥳

Thanks for your review, will adresse all of this

Hey! That’s probably because I haven’t pull from main for a while and we changed the whisper tokenizer. As you can see the decoding process is the one failing here