Radiobox doesn't accept enter event

Open jdfa opened this issue 3 years ago • 3 comments

RadioboxBase::OnEvent returns false for Event::Return: https://github.com/ArthurSonzogni/FTXUI/blob/24e04faf36bf0954272200b0bf51c4305e8b8dfc/src/ftxui/component/radiobox.cpp#L107

Sep 28 '22 15:09 jdfa

Yes, I believe you are right. Do you want to submit a PR fixing this?

Sep 29 '22 09:09 ArthurSonzogni

Yes, I can do that. Do we need to pass event further if current radiobutton was selected before current event?

Sep 30 '22 22:09 jdfa

Yes, I believe we should return true unconditionnally.

Oct 01 '22 09:10 ArthurSonzogni