Arthur Silva Sens

Results 418 comments of Arthur Silva Sens

Manual tests are showing that I broke the current behavior that extracts attributes from `otel_scope_info` metrics and when the feature gate is enabled, I'm getting nil pointers xD Back to...

Still working on this and still strugging to fix it. I've changed the test strategy to something that tests more end2end, and this one triggers the nilpointers I'm seeing when...

I was traveling for a few weeks. I'm reopening since this is still important

> some initial questions on the design as I take over this PR as we discussed. Let's chat about them, maybe tomorrow? absolutely!

Ok, I finally found some time to get back to this. I ended up fixing the previous problems by introducing an interface. I was afraid this would introduce some performance...

> I think we should proceed with whatever you have working, and open an issue with your profiles, etc to look into optimizing that code path. Once the `otel_scope_info` functionality...

> I imagine people will have a mix of clients for some time. Some will use the new scope attributes on metrics, and others will still be using otel_scope_info. I...

Okay, I've added a commit changing the behavior of the feature gate. Now, we're always parsing attributes from labels prefixed with `otel_scope_`, and the feature gate controls whether we merge...

> Approved with some small corrections. Also as per WG decision, you'll need another approval. Thanks for clarifying about exemplars :)

Comments addressed, thanks for the review! > I wonder if @ct needs to be prohibited explicitly for gauges, gauge histograms and alike. The ABNF does allow it, so syntax doesn't...