Arthur Silva Sens

Results 418 comments of Arthur Silva Sens

I guess we could test this behavior using the runtime package? More precisely, using `runtime.NumGoroutine()`(https://pkg.go.dev/runtime#NumGoroutine) Verify the number of goroutines, execute the function you believe there is a leak, and...

It's debatable. I think we are able to ingest resource attributes but we're still not sure if the solution we have is our final solution. I'd keep this issue open...

> Open questions > > * Investigate sharding implementation for additionalScrapeConfigs. I believe we want to deprecate `additionalScrapeConfigs` after ScrapeConfig CRD became a thing, couldn't we just ignore or document...

Changing behavior after we implement the API (using dots once Prometheus supports it) doesn't sound like a good approach, so I would say yes if we put this behind a...

Let's remove the Admin API stuff, or find a better home for it. Additionally, we can repeat the same behavior we have with podmonitors in this page, but with servicemonitors

> I haven't followed the redesign very closely but if we're removing the installation instructions, will it be obvious for the reader where they can be found? It's here now:...

Working on platform guide first makes sense to me :)

> Now that #6887 has been merged, we have added the Getting-Started page in the Platform Guide. If no further changes are required, we can also merge this one. I...

> API Reference(for service and pod monitors) That looks like a perfect fit for "what's next"! Even better if we can point specifically to the ServiceMonitor or PodMonitor specs

I agree that completely removing the option to set `continue: false` from users is not ideal and would love to see a more flexible approach :), at the same time...