Arthur Silva Sens

Results 418 comments of Arthur Silva Sens

@aknuds1 @ywwg @npazosmendez this should be ready for a review :) Note that I'm not changing how we handle unit/type suffixes here, this PR does not introduce any name collision...

Folks, I've messed up my commits here 😓. Let's get [this one merged first](https://github.com/prometheus/prometheus/pull/15249) and I'll figure out what to do here later

Lol ok, after merging the chained PR the branch got automatically deleted and messed up this PR. I'll open another one, sorry everyone

> Nice! @ArthurSens do you think there are some tests to be updated/added for this? Especially around scrape loop. I believe so, yes. I believe in our last call we...

Also, it is fine to keep this as a follow up PR, but the test is getting quite big 😅 Maybe we want to split the set-up of the test...

The PR title `feat: default NewOpenMetricsParser to skip created timestamps` seems a little bit incorrect. I wouldn't call this a feature, but a CHANGE. We're no longer ingesting OpenMetrics series...

Test failure message ``` panic: test timed out after 30s running tests: TestManagerCTZeroIngestionHistogram (30s) TestManagerCTZeroIngestionHistogram/disabled_with_CT_on_histogram (30s) goroutine 45 [running]: testing.(*M).startAlarm.func1() /Users/arthursens/go/pkg/mod/golang.org/[email protected]/src/testing/testing.go:2366 +0x1dc created by time.goFunc /Users/arthursens/go/pkg/mod/golang.org/[email protected]/src/time/sleep.go:177 +0x44 goroutine 1 [chan...

Alright, only 1 test is failing now: `TestHeadAppender_AppendHistogramCTZeroSample`. What this test does is ingest Histogram samples with created timestamps in several different scenarios. Some of those scenarios should reject the...

> Appender tries to set the counter reset to either 1 or 2 (detected reset, detected no reset) to help PromQL. > Also if I understand correctly, the zero histogram...

Converted to draft while I work on the failing test in head_appender