Android-Image-Cropper icon indicating copy to clipboard operation
Android-Image-Cropper copied to clipboard

fix npe issue https://github.com/ArthurHub/Android-Image-Cropper/issues/551

Open donfuxx opened this issue 5 years ago • 9 comments

see related issues #551 #616

Caused by java.lang.NullPointerException: Attempt to invoke virtual method 'android.os.Parcelable android.os.Bundle.getParcelable(java.lang.String)' on a null object reference
at com.theartofdev.edmodo.cropper.CropImageActivity.onCreate(CropImageActivity.java:63)

Fix by finishing the CropImageActivity gracefully (which gives the user the opportunity to try selecting an image again) instead of app crash.

donfuxx avatar Jan 22 '19 22:01 donfuxx

@donfuxx when it is planned to merge it? I see it's still open...

tomerpetel avatar Aug 04 '19 06:08 tomerpetel

Hi @tomerpetel ! Unfortunately I don't have write access to this repository. It's up to @ArthurHub to review and merge this ;-)

donfuxx avatar Aug 04 '19 08:08 donfuxx

Thx @donfuxx, @ArthurHub is it possible to review this fix and merge if passed?

tomerpetel avatar Aug 04 '19 08:08 tomerpetel

@tomerpetel It doesn't look that @ArthurHub is actively maintaining this. You may need to clone the repo and apply the PR fix in your cloned code. Or maybe choose another image cropper?

mirono avatar Oct 08 '20 10:10 mirono

@mirono do you have any suggestions for another cropper? (lol)

manuelrego27 avatar Nov 10 '20 18:11 manuelrego27

@manuelrego27 Never tried it myself but https://github.com/Yalantis/uCrop looks promising. At least it is actively maintained.

mirono avatar Nov 10 '20 20:11 mirono

Hey!

I start a new project to handover this library https://github.com/CanHub/Android-Image-Cropper

The ideia is that we keep improving because this project don't have updates since 2018 Hope I can count with your help.

Open to contribute, next pieces of work will be Android 11 permissions, refactor into Kotlin and ActivityContract

Canato avatar Nov 27 '20 16:11 Canato

I will be happy to help.

mirono avatar Nov 27 '20 17:11 mirono

holy shit, thank you @Canato !!!

manuelrego27 avatar Nov 28 '20 14:11 manuelrego27