Arthur Halet

Results 16 comments of Arthur Halet

@smukil could you merge this ? it actually looks like author take all your remarks from original PR and do the changes and you needed only those changes before merging...

I'm preparing a v2 which remove a lot of dependencies to make project smaller, i will see it in the same time. Thank you for your report

I like the idea with the a simple map, i've just put on comment but all seems good to me

As you can see I've didn't do the Update case in unit test, I had this issue and that's really good that you leverage this point. I need more your...

hello @jmcarp thank for the feedback. Do you have a kind of usecase where you need this ? If you remove it actually it will do the same final effect...

yes it makes sense and i was thinking about before your answered and wanted to say that was a good idea.