Kijiji-Repost-Headless icon indicating copy to clipboard operation
Kijiji-Repost-Headless copied to clipboard

Choose most relevant category relating to Model?

Open munibrahman opened this issue 7 years ago • 8 comments

Hi,

When creating an item.enf file for a car, it asks for the make, and when the make is entered it asks for the model but the choices are:

1 G80 2 G90

What does this stand for? Thanks

munibrahman avatar Nov 27 '17 08:11 munibrahman

After a quick web search it would appear that the "G80" and "G90" are car models under the Genesis brand. Did you select "Genesis" as the make?

This could be related to issue #35 with regard to choosing make + model as these two attributes are closely coupled making it difficult to auto-generate.

jackm avatar Nov 27 '17 19:11 jackm

I choose BMW as my model. I think this might be related, is there a fix?

munibrahman avatar Nov 27 '17 21:11 munibrahman

Confirmed that no matter what make of vehicle you choose, there are only ever two models: "G80" and "G90".

Having looked at the kijiji_categories_attrs.json file, these are actually the only two models listed under the carmake_s+carmodel_s attribute id. Seems like it's missing all others. My guess is when this json file was generated, the person had the "Genesis" car make selected which is why only those two models were picked up.

You must have been the first one to try and generate an ad inf file for a vehicle ad. The Kijiji site populates the "Make:" dropdown list only once you've selected a vehicle make first.

As a temporary workaround, you could select an arbitrary vehicle model, finish generating the inf file and then afterwards manually edit the inf file and change the carmake_s+carmodel_s attribute to match the correct vehicle model. You just have to make sure that you set it to match what the corresponding HTML option tag "value" attribute is set to (ie. <option value="somevalue">Option name</option>). For example, the BMW "M Roadster & Coupe" model has an option tag value equal to "mrdstcoup".

jackm avatar Nov 30 '17 01:11 jackm

Seems like the same issue as #35, I don't see any simple way to fix this without pulling the correct attributes when the attributes file is generated. Even then, there will be some very ugly traversing to find out the attributes that are allowed.

Thoughts?

ArthurG avatar Dec 03 '17 20:12 ArthurG

Dont fix this, this will lead to car dealers using this script. There are ways for intelligent individuals to get this working as has been stated already, I can confirm reposting with cars/motorbikes or others with this error still works as long as user has some intelligence in making their ads

cerberii avatar Dec 04 '17 19:12 cerberii

Car dealers probably don't need to use this script. They have access to AdMarkt, provided by kijiji themselves. I do agree that you can post ads with a little bit of tweaking, but that defeats the whole purpose of automation of ad postings. There is a small bug in the code and its kind of silly in my opinion to justify its existence.

munibrahman avatar Dec 04 '17 22:12 munibrahman

Seems like the same issue as #35, I don't see any simple way to fix this without pulling the correct attributes when the attributes file is generated. Even then, there will be some very ugly traversing to find out the attributes that are allowed.

Thoughts?

How is the original file being generated? Is it possible to use some sort of object data structure to store these values?

munibrahman avatar Dec 04 '17 22:12 munibrahman

Is it possible to use some sort of object data structure to store these values?

Since it's currently stored in JSON, we currently only have are dictionaries and arrays... Creating the dictionary that maps between carmakes and carmodels will be very hard IMO.

If you have any ideas, please feel free to open a PR.

ArthurG avatar Dec 04 '17 23:12 ArthurG