ROMP icon indicating copy to clipboard operation
ROMP copied to clipboard

'with_renderer' argument raises TypeError

Open uyoung-jeong opened this issue 2 years ago • 1 comments

I tried to test the dataset loading process as described in https://github.com/Arthur151/ROMP/blob/master/docs/dataset.md python -m romp.lib.dataset.lsp

It raised an error as below: visualizer = Visualizer(resolution = (512,512,3), result_img_dir=save_dir,with_renderer=True) TypeError: __init__() got an unexpected keyword argument 'with_renderer'

This error occured in the line https://github.com/Arthur151/ROMP/blob/7b4734270672e602f4fc5659d37479478e72b78b/romp/lib/dataset/image_base.py#L485

Initialization function of visualizer does not have such argument: https://github.com/Arthur151/ROMP/blob/7b4734270672e602f4fc5659d37479478e72b78b/romp/lib/visualization/visualization.py#L28

Is this an obsolete argument or did I miss something?

uyoung-jeong avatar Apr 24 '22 17:04 uyoung-jeong

I fixed the 485th line of image_base.py as below, and it works. visualizer = Visualizer(resolution = (512,512,3), result_img_dir=save_dir, renderer_type=args().renderer)

uyoung-jeong avatar Apr 24 '22 18:04 uyoung-jeong