StarterHive icon indicating copy to clipboard operation
StarterHive copied to clipboard

🔴 BUG: Navigation drawer not closing

Open rahilansari261 opened this issue 1 year ago • 9 comments

Navigation drawer not closing

When navigating to other pages by clicking navigation items it should close the navigation drawer

Expected behaviour It should close the navigation drawer as we tap any item of the navigation drawer and navigate to the tapped page

rahilansari261 avatar Jun 20 '23 15:06 rahilansari261

Can I be assigned to this issue? I would like to work on this issue.

Sivasish48 avatar Jun 21 '23 04:06 Sivasish48

Sure @Sivasish48 . Assigned to you.

ArslanYM avatar Jun 21 '23 17:06 ArslanYM

Can I get more detailed information about the issue?

Sivasish48 avatar Jun 23 '23 03:06 Sivasish48

@Sivasish48 You should ask these type of questions before getting assigned to it. Anyways, the issue is when we navigate on small screen devices using the hamburger navbar, The hamburger doesnt close and stays opened.

ArslanYM avatar Jun 23 '23 09:06 ArslanYM

Hey @Sivasish48, let me know if you need any help on this I think it would be better to change the hamburger icon to an icon like 'X' when it is open, @ArslanYM what do you think about this?

ashishratre404 avatar Jun 26 '23 18:06 ashishratre404

Yess. I was also thinking about that X icon as well.. @ArslanYM would that be good?

Sivasish48 avatar Jun 27 '23 02:06 Sivasish48

That's not the issue though, The 'X' when the drawer is open would be a feature but the issue here is to close the drawer when navigating to another page. @Sivasish48 Why has there been no update on this?

ArslanYM avatar Jun 27 '23 04:06 ArslanYM

can I work on this? @ArslanYM

ashishratre404 avatar Jul 10 '23 10:07 ashishratre404

@ashishratre404 Sure, Assigned to you. PR soon!

ArslanYM avatar Jul 10 '23 15:07 ArslanYM