StarterHive icon indicating copy to clipboard operation
StarterHive copied to clipboard

🔴 BUG: Navbar light mode text contrast change

Open AshwanthramKL opened this issue 1 year ago • 12 comments

Describe the bug According to color theory, grey and yellow don't go well with each other.

To Reproduce Steps to reproduce the behavior:

  1. Go to website and observe the navbar

Expected behavior

A better suggestion would be to use the same background color for the text color (white) Could have something like this. image

Screenshots image

Additional context Add any other context about the problem here.

AshwanthramKL avatar Jun 13 '23 07:06 AshwanthramKL

Hi, there is a discussion about this here If you have some ideas would be nice :)

ThGnommy avatar Jun 13 '23 08:06 ThGnommy

will you assign this work for me... I'll make it better for you!

Aswin-Inigo avatar Jun 15 '23 07:06 Aswin-Inigo

I think @MuhammadRabi is already working on it.

ArslanYM avatar Jun 15 '23 07:06 ArslanYM

Okay.. Fine, let me know if @https://github.com/MuhammadRabi need some help..

Aswin-Inigo avatar Jun 15 '23 07:06 Aswin-Inigo

I think @MuhammadRabi is already working on it.

@ArslanYM unfortunately, I didn't work on this one, But I opened a related issue #219

MuhammadRabi avatar Jun 15 '23 09:06 MuhammadRabi

@ArslanYM can you assign this to me, want to give it a try!

vishalsingh2972 avatar Jul 02 '23 14:07 vishalsingh2972

@vishalsingh2972 Sure thing. Assigned to you.

ArslanYM avatar Jul 03 '23 03:07 ArslanYM

@ArslanYM a small doubt, so as per logic have made the necessary corrections but need help I want to see/check the output of the changes in the frontend. Have never worked with react so can someone please help me with this

vishalsingh2972 avatar Jul 03 '23 14:07 vishalsingh2972

@vishalsingh2972 If you havent worked with React, how do you plan on solving this issue? This project requires atleast the ground knowledge of React and Tailwind.

ArslanYM avatar Jul 03 '23 16:07 ArslanYM

Here's the development guide : https://github.com/ArslanYM/StarterHive/tree/main/web#readme

ArslanYM avatar Jul 03 '23 16:07 ArslanYM

@vishalsingh2972 If you haven't worked with React, how do you plan on solving this issue? This project requires atleast the ground knowledge of React and Tailwind.

I apologize for my misunderstanding. Although I haven't worked with React/Tailwind, I have previously solved similar issues using Vanilla JS, so thought of giving this a try!

vishalsingh2972 avatar Jul 03 '23 17:07 vishalsingh2972

Hey If this issue is open I wanted to work on it and I have some doubts that we only have to change the colour on the active link or maybe whenever we hover it will change the colour of never links from grey to White

kumar2023jha2000 avatar Aug 28 '23 12:08 kumar2023jha2000