Qt-calculator icon indicating copy to clipboard operation
Qt-calculator copied to clipboard

Changing the theme of the calculator

Open Arsenic-ATG opened this issue 3 years ago • 42 comments

current theme of calculator is pretty basic, it would be amazing to have different themes of the same.

if anyone have any ideas regarding the same then they can discuss it here.

ideas may include changes in :-

  1. layout
  2. colour pallet
  3. overall design

Arsenic-ATG avatar Aug 15 '20 04:08 Arsenic-ATG

The buttons are too edgy, round edges would be nicer.

IshuSingh1 avatar Sep 22 '20 15:09 IshuSingh1

@IshuSingh1 thanks for the suggestion 😃

here is how calculator will look after the corners would be rounded👇

rounded corner theme

Arsenic-ATG avatar Sep 23 '20 02:09 Arsenic-ATG

Add some margin between buttons if possible. Add some margin between border of calculator and buttons Buttons looks to big. reduce padding on buttons.

I did not this issue first so I had opened another issue.

vivek80801 avatar Oct 02 '20 00:10 vivek80801

Thanks @vivek80801 for the suggestion 😃

I would be working on it, or if you want to work on it then do let me know.

Arsenic-ATG avatar Oct 02 '20 04:10 Arsenic-ATG

@ahmedellord56 changing the front end requires pure CSS skills : -

  1. Set up the Qt creator and get the project configured on as instructed in README.md file

  2. Go to mainwindow.ui inside the foler Forms Screenshot 2020-10-18 at 6 50 52 AM

  3. Select the area you want to alter ( for example let say you want to change the colour of a button, so click on the required button) and then search for its stylesheets and alter them accordingly. Screenshot 2020-10-18 at 6 57 50 AM

  4. Commit your changes to your fork and then open a pull request here.

If still something is left unclear regarding the project or Qt Creator then feel free to ask it here or open a new issue regarding the same.

⚠️ ScreenShots used here are taken on a system running macOS operating system, results may vary depending on the operating system you are running in your device

Arsenic-ATG avatar Oct 18 '20 01:10 Arsenic-ATG

@ahmedellord56

there is design button on left sidebar in qt creator. you can also use that.

vivek80801 avatar Oct 18 '20 02:10 vivek80801

Can I contribute to the project by changing the sequence of the numbers and also adding some more buttons?

SakshiZ9 avatar Nov 21 '20 15:11 SakshiZ9

@SakshiZ9 why not, go for it.🙂 I would be waiting for your contribution

Arsenic-ATG avatar Nov 21 '20 15:11 Arsenic-ATG

@SakshiZ9 we will love to see your contributions. If you have some questions feel free to ask. We will try to give answers as soon as possible.

vivek80801 avatar Nov 23 '20 09:11 vivek80801

I have made few changes and requested a pull request. Kindly let know to add any changes in the project.

SakshiZ9 avatar Nov 24 '20 13:11 SakshiZ9

@SakshiZ9 I can't see any pull request on this repository or on your fork, are you sure you pushed the commits to your remote repository after doing all the changes in your local repository. or either you have not committed those changes.

Arsenic-ATG avatar Nov 24 '20 14:11 Arsenic-ATG

Okay. I tried it again, is there any pull request from my side?

SakshiZ9 avatar Nov 24 '20 14:11 SakshiZ9

Hi guys, i would like to contribute to this project is there anything where I can contribute @Arsenic-ATG
@vivek80801

eraviral34 avatar Dec 03 '20 08:12 eraviral34

Hi guys, i would like to contribute to this project is there anything where I can contribute @Arsenic-ATG @vivek80801

@eraviral34 thanks for choosing this repository to contribute, we love contributions 🙂

right now there are 3 places where you can contribute : -

  1. changing the front end of the calculator
  2. working on backend or adding more functionality to the calculator (like discussed in this issue ) if you want to add any other functionality then just open a new issue regarding the same.
  3. contributing on documentation :- if you find any fault/typo in documentation ( readme.md, contributing.md etc) or you think there is something this you could have explained better or something then feel free to change it and send a PR for us to review and merge

Arsenic-ATG avatar Dec 03 '20 08:12 Arsenic-ATG

I would like to work more on a backend

eraviral34 avatar Dec 03 '20 08:12 eraviral34

@eraviral34 good, then you can either work on the scientific calculator issue or open a new one regarding any functionality you wish to add

Arsenic-ATG avatar Dec 03 '20 08:12 Arsenic-ATG

@Arsenic-ATG About the theme, we can try vibrant colors for operator buttons. For example, I designed this simple CSS to show image

iPraveenParihar avatar Jan 18 '21 15:01 iPraveenParihar

@iPraveenParihar that looks amazing. I would look forward to adding those soon.

Or

Are you interested in doing it yourself ?

Arsenic-ATG avatar Jan 18 '21 16:01 Arsenic-ATG

@Arsenic-ATG, Not now currently working on another project. And also am not familiar with QT

iPraveenParihar avatar Jan 19 '21 03:01 iPraveenParihar

@iPraveenParihar Thanks for redesigning the app. QT has GUI to do to design the app. all the code will generated by that QT itself.

@Arsenic-ATG Can I try to implement new design ?

vivek80801 avatar Jan 19 '21 11:01 vivek80801

sure @vivek80801 , go for it.

btw, you can also override the CSS manually of the calculator according to you.

Arsenic-ATG avatar Jan 19 '21 11:01 Arsenic-ATG

@Arsenic-ATG Can we add a dark mode to the calculator?? I am suggesting for dark mode for buttons also.

sheharyaar avatar Feb 12 '21 19:02 sheharyaar

@sheharyaar sure, go ahead. If you want any help from me about the project of Qt in general then feel free to ask.

Arsenic-ATG avatar Feb 13 '21 08:02 Arsenic-ATG

@Arsenic-ATG Hey, can I contribute to this and make a "matrix" (think green on black) styled theme?

Paiz0 avatar Sep 27 '21 01:09 Paiz0

@Arsenic-ATG Hey, can I contribute to this and make a "matrix" (think green on black) styled theme?

Sure go for it.

Arsenic-ATG avatar Sep 27 '21 03:09 Arsenic-ATG

  • { padding: 0; margin: 5px; text-align: center; } body { background-color:blue; } .calculator { width: 350px; height: 320px; background-color: #c0c0c0; box-shadow: 0px 0px 0px 10px #666; border: 5px solid black; border-radius: 10px; } #display { width: 320px; height: 40px; text-align: right; background-color: black; border: 3px solid white; font-size: 18px; left: 2px; top: 2px; color: #7fff00; } .btnTop{ color: white; background-color: #6f6f6f; font-size: 14px; margin: auto; width: 50px; height: 25px; } .btnNum { color: white; background-color: black; font-size: 14px; margin: auto; width: 50px; height: 25px; } .btnMath { color: white; background-color: #ff4561; font-size: 14px; margin: auto; width: 50px; height: 25px; } .btnOpps { color: white; background-color: #ff9933; font-size: 14px; margin: auto; width: 50px; height: 25px; } function addChar(input, character) { if(input.value == null || input.value == "0") input.value = character else input.value += character }

function cos(form) { form.display.value = Math.cos(form.display.value); }

function sin(form) { form.display.value = Math.sin(form.display.value); }

function tan(form) { form.display.value = Math.tan(form.display.value); }

function sqrt(form) { form.display.value = Math.sqrt(form.display.value); }

function ln(form) { form.display.value = Math.log(form.display.value); }

function exp(form) { form.display.value = Math.exp(form.display.value); }

function deleteChar(input) { input.value = input.value.substring(0, input.value.length - 1) } var val = 0.0; function percent(input) { val = input.value; input.value = input.value + "%"; }

function changeSign(input) { if(input.value.substring(0, 1) == "-") input.value = input.value.substring(1, input.value.length) else input.value = "-" + input.value }

function compute(form) { //if (val !== 0.0) { // var percent = form.display.value;
// percent = pcent.substring(percent.indexOf("%")+1); // form.display.value = parseFloat(percent)/100 * val; //val = 0.0; // } else form.display.value = eval(form.display.value); }

function square(form) { form.display.value = eval(form.display.value) * eval(form.display.value) }

function checkNum(str) { for (var i = 0; i < str.length; i++) { var ch = str.charAt(i); if (ch < "0" || ch > "9") { if (ch != "/" && ch != "*" && ch != "+" && ch != "-" && ch != "." && ch != "(" && ch!= ")" && ch != "%") { alert("invalid entry!") return false } } } return true }

Screenshot (158)

Codebat-man avatar Oct 05 '21 13:10 Codebat-man

What are the demands/requirements for themes that have to be met in this project?

I'm interested to contribute here

thegarvitrai avatar Dec 16 '21 06:12 thegarvitrai

What are the demands/requirements for themes that have to be met in this project?

I'm interested to contribute here

There aren't any specific requirements for the theme apart from the fact that it should cover all the functional buttons on the calculator, feel free to take full creative freedom with the UI.

Arsenic-ATG avatar Dec 16 '21 08:12 Arsenic-ATG

Hey @Arsenic-ATG I am new to open source issues, and was wondering if I could help with the front end of this calculator. Maybe add a Rainbow Theme or some other theme if that one has already been accomplished.

QDaily117 avatar Jan 22 '22 19:01 QDaily117

Hey @Arsenic-ATG I am new to open source issues, and was wondering if I could help with the front end of this calculator. Maybe add a Rainbow Theme or some other theme if that one has already been accomplished.

Hi @QDaily117 (sorry for late reply) Could you please elaborate a bit about what exactly do you mean by rainbow theme ? or better send in a PR with the changes and we can check/alter the theme during review process only. 👍

Arsenic-ATG avatar Jan 23 '22 15:01 Arsenic-ATG