mlconjug3 icon indicating copy to clipboard operation
mlconjug3 copied to clipboard

Portuguese conjugation data file has some issues

Open zelenij opened this issue 3 years ago • 3 comments

Describe the bug It seems to me that the file mlconjug3/data/conjug_manager/conjugation-pt.json has a few invalid forms. For example, when I conjugate falar through the library, I get:

Indicativo pretérito perfeito simples: falar

nós "fal)" - yes, including the closing parenthesis, and not "falámos". And looking in the file, I indeed see ")" appearing in a few places. This looks very odd to me.

To Reproduce

Conjugate the Portuguese verb falar in Indicativo pretérito perfeito simples

Expected behavior

nós falámos

On closer inspection, I don't see a single instance of the suffix "ámos" for any verb in the file for "Indicativo pretérito perfeito simples". This doesn't look right to me. Sample conjugation: https://conjugador.reverso.net/conjugacion-portugues-verbo-comprar.html

zelenij avatar Jun 27 '21 03:06 zelenij

Hi @zelenij , thank you for using mlconjug3 and for reporting this issue.

I am sorry I couldn't reply before as I was sick with covid and had to lay low for a while. I am now back in business though, so I will investigate this issue ASAP.

Would you be willing to beta-test the next release to double check if the Portuguese data is correct?

Thank you in advance

SekouDiaoNlp

SekouDiaoNlp avatar Oct 30 '21 16:10 SekouDiaoNlp

I'm glad you are feeling better.

Sure, I can try out the new version

zelenij avatar Nov 01 '21 12:11 zelenij

Hi @zelenij I should release the latest version of mlconjug3 with the fixes in the next few days.

SekouDiaoNlp avatar Feb 03 '22 14:02 SekouDiaoNlp