Aron Adler

Results 47 comments of Aron Adler

Thanks for submitting this! Can a maintainer merge this please? 🙏

Because you can just add a thumbs up to the original comment, adding a separate comment purely to say '+1' doesn't add much.

I'm on Cloud v4.0 EDIT: unless you meant the npm deps, in which case they are `"edgedb": "^1.4.0"` and `"@edgedb/generate": "^0.4.0"`

I can't really wrap my head around the type generation code, but this does seem to fix my use case! ![image](https://github.com/edgedb/edgedb-js/assets/13225609/b3756989-6116-4efb-bb93-ed001b803e66)

There seems to be something wrong with the default exports though. I'm getting this, but the one at the bottom looks very off. ![image](https://github.com/edgedb/edgedb-js/assets/13225609/539d72e0-6cd2-463c-9c97-24d14d87e728) I'm guessing it's from this part...

I don't really understand how `TypeSet` works, but it seems wrong that it contains `Cardinality.AtMostOne | Cardinality.One | Cardinality.Empty` when this field only has a cardinality of exactly `Cardinality.One`? ![image](https://github.com/edgedb/edgedb-js/assets/13225609/6f28fe47-cd92-4e1b-8616-707cfad505a6)

Hey @scotttrinh, just checking in on this PR. I don't know if this was ready to merge or not, was it waiting on anything else?

Ah gotcha. Do I need to copy and paste or import the code from the other files, or is it sufficient that my code is in the same directory as...

What about instead of always getting the full name of the provided type exactly as is, we get the generic version of the type, both when inserting into the map...

One question that arises with the above is whether we want to include logic for supporting different coders for the same type if it has different type parameters set. I.e....