Ray Knight

Results 23 comments of Ray Knight
trafficstars

Had to update `Object.entries(nextSlots)` to `Reflect.ownKeys(nextSlots)` due to RAC's use of symbols with `DEFAULT_SLOT`

I do like your suggestion of having the merge logic be applied on a per context basis, I might update my own API to be structured that way. I've had...

Yup, this would absolutely be a breaking change, but in the name of consistency, flexibility and extensibility. And just to reiterate, this is not exclusive to the ListBox. It is...

A more concrete example would be to implement a De/Select All button. This would contextually need to know the state of the whole collection, what is currently selected, and access...

I'll check out the PR you linked in detail tomorrow. In the meantime, my gut reaction to how to make the original proposal work would be to have `` be...

True, the initial render would be guaranteed to have an empty collection in the case of static jsx options (items prop would fulfill per usual, immediate if static, on second...

Alternative approach: Support a third type of rendering combination - Approach 1: items is undefined, children are static jsx collection items - Approach 2: items is an array, children is...

I'd like to request that `Hidden` and `createHideableComponent` also be exported as part of this effort, for the simplicity of implementation and completeness of feature suite

@devongovett It looks like the `HiddenContext` was not exported in the new `@react-aria/collections` or through `react-aria-components`. This means that the `HiddenContext` can't be reused as a provider I'd like to...

Also, it feels a little weird that the whole hidden suite got rolled into collections considering it's used by components like `Button` that have no connection with collection at all