atom-zentabs icon indicating copy to clipboard operation
atom-zentabs copied to clipboard

Close pin tabs

Open anatooly opened this issue 9 years ago • 4 comments

Why closed pinned tabs? 'Close all tabs' - closed pinned tabs, this not right. 'Close Tabs to the Right' closed pinned tabs too, this not right.

I pinned some two tabs. Then I open many other tabs and I need close all without my pinned.

anatooly avatar Jun 26 '15 08:06 anatooly

The Close other tabs and Close Tabs to the Right are not implemented by this package but by the core tabs package. This core package has no clue about the pinned feature. There is nothing I can do at this plugin level.

I'll see how to act on the tabs package level but can't promise anything.

ArnaudRinquin avatar Jul 31 '15 11:07 ArnaudRinquin

Similarly If one presses the shortcut to close a tab, it shouldn't do anything if the current tab is a pinned one.

Actually Chrome doesn't behave like that (one can command + W pinned tabs) but I find that to be nonsense, quite objectively.

Cheers - Victor

vemv avatar Oct 18 '15 19:10 vemv

Sorry @vemv for the huge answering delay ; I just did not see or forgot about your message.

The pin mechanism is very specific to ZenTabs, not Atom. AFAIK, the closing shortcut cmd+w is something ZenTabs can't override. Maybe I can. Feel free to search API doc for it ;)

ArnaudRinquin avatar Feb 02 '16 10:02 ArnaudRinquin

FYI, I created a pull request that adds the Pin tab feature to the core tabs components. It will be merge one day (hopefully) so this extension can be updated accordingly.

In the meantime, there is nothing else I can do.

ArnaudRinquin avatar Feb 15 '16 16:02 ArnaudRinquin