ngx-matomo icon indicating copy to clipboard operation
ngx-matomo copied to clipboard

Published 20 hours ago • verified publisher icon Arnaud73

Angular 13 compatibility

Open nicolasalcina opened this issue 3 years ago • 13 comments

in Angular 13, NgModuleFactoryLoader was removed

See here : https://update.angular.io/?l=3&v=12.0-13.0 last point : The route package no longer exports SpyNgModuleFactoryLoader and DeprecatedLoadChildren. In case you use them, make sure you remove their corresponding import statements.

error on build : Error: node_modules/ngx-matomo/node_modules/@angular/router/router.d.ts:21:10 - error TS2305: Module '"@angular/core"' has no exported member 'NgModuleFactoryLoader'.

nicolasalcina avatar Nov 05 '21 11:11 nicolasalcina

Any chance to release an angular 13 version @Arnaud73?

Or @nicolasalcina to do a fork + MR to fix the problem?

sinsunsan avatar Nov 22 '21 22:11 sinsunsan

@nicolasalcina did you found solution? I was preparing myself to do a fork and dive into the problem, but maybe it is already fixed for you?

sinsunsan avatar Dec 03 '21 15:12 sinsunsan

I found those issue https://github.com/angular/universal/issues/2451 and the changelog referring to the deprecation https://github.com/angular/angular/blob/master/CHANGELOG.md#1300-2021-11-03

but I don't see any use of this deprecated import in the project....

@nicolasalcina

sinsunsan avatar Dec 06 '21 15:12 sinsunsan

Ok I got it https://github.com/Arnaud73/ngx-matomo/pull/69/files It was only needed to update the peerDependencies to angular 13 minimum in the package.json of the lib.

Here is an MR https://github.com/Arnaud73/ngx-matomo/pull/69/files

I also did a temporary deploy with name sinsunsan-ngx-matomo "sinsunsan-ngx-matomo": "0.1.5" so that we don't need to wait @Arnaud73 to merge

sinsunsan avatar Dec 06 '21 16:12 sinsunsan

Perfect thank you Sorry, got not enough time to watch this, I stayed in ng12 for this time ;)

nicolasalcina avatar Dec 06 '21 20:12 nicolasalcina

Any update on Angular 13 compatibility?

jeuriz-fadv avatar Jan 18 '22 13:01 jeuriz-fadv

@Arnaud73 , Can you please take a look at this PR https://github.com/Arnaud73/ngx-matomo/issues/68#issuecomment-986940538? And merge if applicable?

khaled4vokalz avatar Mar 14 '22 08:03 khaled4vokalz

Ok I got it https://github.com/Arnaud73/ngx-matomo/pull/69/files It was only needed to update the peerDependencies to angular 13 minimum in the package.json of the lib.

Here is an MR https://github.com/Arnaud73/ngx-matomo/pull/69/files

I also did a temporary deploy with name sinsunsan-ngx-matomo "sinsunsan-ngx-matomo": "0.1.5" so that we don't need to wait @Arnaud73 to merge

Thank you very much. You saved my day.

KamranTaghaddos avatar Apr 04 '22 10:04 KamranTaghaddos

is this fix available in latest deployment, else any workaround ?

mayur-gharat avatar May 05 '22 16:05 mayur-gharat

@sinsunsan , Is this issue resolved? I am still facing issue while upgrading my application from Agnular12 to Angular13

mayur-gharat avatar May 10 '22 13:05 mayur-gharat

Does anyone know if the matomo package is maintained? Because we have been waiting for the version upgrade to Angular 13 for several months. A pull request is in progress, but apparently the owner does not want to integrate it, or he is too busy. It's a shame, I don't think I'm the only one in this situation....

ambarkiy avatar May 15 '22 06:05 ambarkiy

We chose to switch to @ngx-matomo/tracker where we got an immediate fix to a configuration issue - so actively maintained! Works perfectly and no issues found after the fix

jonhamm avatar May 15 '22 08:05 jonhamm

I just looked, the package looks very elegant and intuitive. I will integrate it in the week.

Thanks for your help.

ambarkiy avatar May 15 '22 10:05 ambarkiy