Performance issue in /read_input.py (by P3)

[DLPerf]

Hello! I've found a performance issue in /read_input.py: dataset.batch(batch_size=batch_size)(here) should be called before dataset.map(read_image)(here), , which could make your program more efficient.

Here is the tensorflow document to support it.

Besides, you need to check the function read_image called in dataset.map(read_image) whether to be affected or not to make the changed code work properly. For example, if read_image needs data with shape (x, y, z) as its input before fix, it would require data with shape (batch_size, x, y, z) after fix.

Looking forward to your reply. Btw, I am very glad to create a PR to fix it if you are too busy.

[DLPerf]

Hello, I'm looking forward to your reply~

[Armour]

Hi sorry, I’m very busy recently, feel free to create the PR and I’ll take a look on it, thanks! :)

DLPerf @.***>于2021年11月4日 周四10:29写道：

Hello, I'm looking forward to your reply~

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/Armour/Automatic-Image-Colorization/issues/16#issuecomment-960587784, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABIIDIJETS3IYHFXEGB5P3TUKJG6XANCNFSM5DBGTGUQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

[jdsimcoe]

Reported