core : crash server

[firelook]

I thought this problem was solved:

` Account: 24 (IP: 81.57.196.83) Logout Character:[Ophéliane](GUID: 35) Level: 18

D:\users_sys\games\wow\mangos\git\arkania_ng_434\src\server\game\Movement\Spline \MoveSpline.cpp:258 in Movement::MoveSpline::_updateState ASSERTION FAILED: minimal_diff >= 0 Movement::MoveSpline::_updateState() d:\users_sys\games\wow\mangos\git\arkania_ng_434\src\server\game\movement\spline\movespline.cpp: 258 + 0x1f Unit::UpdateSplineMovement() d:\users_sys\games\wow\mangos\git\arkania_ng_434\src\server\game\entities\unit\unit.cpp: 428 + 0x1c Unit::Update() d:\users_sys\games\wow\mangos\git\arkania_ng_434\src\server\game\entities\unit\unit.cpp: 404 + 0x0 Creature::Update() d:\users_sys\games\wow\mangos\git\arkania_ng_434\src\server\game\entities\creature\creature.cpp: 548 + 0x0 TempSummon::Update() d:\users_sys\games\wow\mangos\git\arkania_ng_434\src\server\game\entities\creature\temporarysummon.cpp: 50 + 0x0Trinity::ObjectUpdater::Visit<Creature>() d:\users_sys\games\wow\mangos\git\arkania_ng_434\src\server\game\grids\notifiers\gridnotifiers.cpp: 342 + 0x0 VisitorHelper<Trinity::ObjectUpdater,Creature,TypeList<DynamicObject,TypeList<Corpse,TypeList<AreaTr☼() d:\users_sys\games\wow\mangos\git\arkania_ng_434\src\server\shared\dynamic\typecontainervisitor.h: 68 + 0x0 Map::Visit<Trinity::ObjectUpdater,TypeMapContainer<TypeList<GameObject,TypeList<Creature,TypeList<Dy☼() d:\users_sys\games\wow\mangos\git\arkania_ng_434\src\server\game\maps\map.h: 743 + 0x0 Map::VisitNearbyCellsOf() d:\users_sys\games\wow\mangos\git\arkania_ng_434\src\server\game\maps\map.cpp: 616 + 0x0 Map::Update() d:\users_sys\games\wow\mangos\git\arkania_ng_434\src\server\game\maps\map.cpp: 661 + 0x0 MapUpdateRequest::call() d:\users_sys\games\wow\mangos\git\arkania_ng_434\src\server\game\maps\mapupdater.cpp: 73 + 0x0 DelayExecutor::svc() d:\users_sys\games\wow\mangos\git\arkania_ng_434\src\server\shared\threading\delayexecutor.cpp: 51 + 0x0 ACE_Task_Base::svc_run() d:\users_sys\games\wow\mangos\git\arkania_ng_434\dep\acelite\ace\task.cpp: 275 + 0x0 ACE_Thread_Adapter::invoke_i() d:\users_sys\games\wow\mangos\git\arkania_ng_434\dep\acelite\ace\thread_adapter.cpp: 161 + 0x5 ACE_Thread_Adapter::invoke() d:\users_sys\games\wow\mangos\git\arkania_ng_434\dep\acelite\ace\thread_adapter.cpp: 96 + 0x9 beginthreadex()+0x107 [0x24f7f] endthreadex()+0x192 [0x25126] BaseThreadInitThunk()+0x1a [0x1842] RtlUserThreadStart()+0x21 [0x14f45]

`

[gpn39f]

Account: 24 (IP: 81.57.196.83) Logout Character:Ophéliane Level: 18 directly on logout char ????

[firelook]

I do not think it is link to the logout. This happened a long time ago and you solved it ;)

[firelook]

since yesterday build (as of compilation of 2/3/2016) the core crash often

[firelook]

nearly every 2 hours of game not quite stable ;) I do manage to have the crash log it is not the one up, I do not see anything.

[gpn39f]

please.. have you some info about this crashs?? map, Zone, character race and class,, bot and bottype.. etc..

[firelook]

this is my problem : I do not manage to find facts (the only thing I see is I have that since the last compilation update)

[gpn39f]

my changes last 14 days was: 2 new helper function in Player.cpp... its only used in gilneas.. then add the phase logic to enable more phases.. only used in gilneas.. and many scripts in gilneas.. nothing more.. so i think this are old failure, but you are in new area/zone and have found them :-) maybe do as before: play only in one zone.. not walking over all maps and instances..

[firelook]

Let' s stay on the first log on the crash => can you reproduce on understand the origin of the crash

[gpn39f]

this we have seen before.. this is a spline value whith a step range width = 0mm.. this is not allowed.. if a opcode packet should be send, the step must have a distance > 0mm..

then i see: TempSummon::Update() i see: Logout Character and my question was: directly on logout char ???? you're answer was not clearly for me..

what i see in you crash: TempSummon... maybe a script, that has generated a npc.. on Unit::UpdateSplineMovement you leave the session.. NOTE: then all player-related -npcs should be despawned.. else a crash occur..

but you can see it self: there is no more info, not about player character, zone, npc, used spell,

if you or youre wife is playing alone, you could use the debug Server.. then i have good chance to find the failure..

before you start debug Play.. we should have same source code to work on.. then i send you my core from now..

[firelook]

unfortunately it was not me who whas playing but a friend, and I have no dates in the logs who can indicate if their is a link between both action (logout and crash)

Due to the fact this can happen, can not we have a kind of security who change the value from 0 to 0,00000001 for example ?

[gpn39f]

no that is not possible.. all core is oop.. https://en.wikipedia.org/wiki/Object-oriented_programming simple demo: you have a Player.. this player have many different stores like: Level, Position, health, damage....every part of this store is done by oop.. we take the Position as demo, position is used by player, items, gameobjects, spells..and many more.. part of Position, is computing 2d and 3d between 2 objects.. all this oop is working with 1 structure called Position.. if i set a security to one of the parameter, then it is working for all different use of Position.. and oop is really deep involved.. nobody can say from what oop function the spline diff from our Position is called.. maybe a bullet from a Canon or a mount or whatever... so you have allways let oop working like the description commands.. and generate a Crash if a value is going outside the function range .. like our core is doing.. and then the debug System help us to find the part that fit wrong values into the Position..

[firelook]

ok crash again so: https://drive.google.com/open?id=0B95KCF0FxhCxN0ZrOURudjhqZlk from visual studio https://drive.google.com/open?id=0B95KCF0FxhCxUGJmTmEwMXZnM2M

the skill "perhaps" at the origin http://fr.wowhead.com/spell=403/eclair or http://fr.wowhead.com/spell=421/chaine-declairs

user :[Ophéliane] the "é" is it a problem ? and the source exe +dll+.... https://drive.google.com/open?id=0B95KCF0FxhCxUFBjU1FsNE5SbWs