Ark icon indicating copy to clipboard operation
Ark copied to clipboard

timestamp unused

Open Loki-Astari opened this issue 3 years ago • 1 comments

Describe the bug

On Linux GCC Compiler we get the following warning:

[ 37%] Building CXX object CMakeFiles/ArkReactor.dir/src/arkreactor/VM/State.cpp.o /home/runner/work/Ark/Ark/src/arkreactor/VM/State.cpp: In member function ‘void Ark::State::configure()’: /home/runner/work/Ark/Ark/src/arkreactor/VM/State.cpp:236:21: error: variable ‘timestamp’ set but not used [-Werror=unused-but-set-variable] 236 | timestamp_t timestamp = 0; | ^~~~~~~~~

To Reproduce Compile on Linux using GCC

Expected behavior There is some effort put into calculating the value of timestamp (see line 246). So it looks like it should be used.

Additional context This should be fixed or the variable removed.

Loki-Astari avatar Oct 16 '21 19:10 Loki-Astari

This value was used to know if we need to recompile a file or not, but we got into a problem: we also need to check the timestamps of the imported files. A second problem appeared in Windows, getting the "last write timestamp" of a file gives us something very wrong (like 36 years in the future).

SuperFola avatar Oct 16 '21 19:10 SuperFola